Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reference): ACT-1471 - Add UI Enhancements #1395

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

aednikanov
Copy link
Contributor

Description

Add UI Enhancements according to the ticket (description only, from the comments we will create a new ticket): https://infura.atlassian.net/browse/ACT-1471

@aednikanov aednikanov requested a review from a team as a code owner July 8, 2024 18:24
Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 6:25pm

@alexandratran
Copy link
Contributor

alexandratran commented Jul 8, 2024

I'm not sure if this is relevant to this PR, but I'm experiencing some unexpected behavior with the array params on Brave browser.

  1. When I type in an array item and press the "enter" key, the entire array is erased – I would expect pressing "enter" would enter the item and take me to the next item (or at least not erase the array).
  2. When I select "Add array item," the new item is populated with the existing list. When I add a new item to the populated list, it treats the entire list as a new array item. I think the UI expects you to replace the populated list with the new item, but this is not intuitive.
Screen.Recording.2024-07-08.at.12.01.46.PM.mov

@alexandratran
Copy link
Contributor

@aednikanov @TrofimovAnton85 ^ It looks like this issue exists prior to this PR. It can be addressed separately.

@aednikanov
Copy link
Contributor Author

@alexandratran thanks. Yeah, we will have a ticket for managing form with keyboard controls. Because the current state regarding this is not ideal, as you see.

@aednikanov aednikanov merged commit 2e3163c into main Jul 9, 2024
6 checks passed
@aednikanov aednikanov deleted the ACT-1471-reference-page-ui-enhancements branch July 9, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants