Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync latest changes from Infura to Services #1528

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Sep 5, 2024

Description

Now that the code freeze is lifted, this PR syncs all currently unsynced changes from Infura to Services – that is, changes from the following Infura PRs:

...plus additional minor changes to related content.

Issue(s) fixed

Fixes #1490
Fixes #1507
Fixes #1508

Preview

https://metamask-docs-m5d7dj7re-metamask-web.vercel.app/services/

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@alexandratran alexandratran requested a review from a team as a code owner September 5, 2024 22:09
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 3:47pm

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just a couple of small minor things.

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 0fa1709 into main Sep 6, 2024
9 checks passed
@alexandratran alexandratran deleted the 1508-sync-infura branch September 6, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants