Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mobile specific RPC method section #161

Merged
merged 3 commits into from
Aug 10, 2020
Merged

Add mobile specific RPC method section #161

merged 3 commits into from
Aug 10, 2020

Conversation

EtDu
Copy link
Contributor

@EtDu EtDu commented Aug 9, 2020 •
edited
Loading

Adds a section for mobile-specific RPC methods. First in the list is wallet_scanQRCode
Should be merged after MetaMask/metamask-mobile#1758

@EtDu EtDu requested review from BboyAkers and a team as code owners August 9, 2020 14:05
BboyAkers
BboyAkers reviewed Aug 10, 2020
View reviewed changes
docs/guide/rpc-api.md Outdated Show resolved Hide resolved
rekmarks
rekmarks approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@rekmarks rekmarks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some edits (and a lint:fix) in 0cf0566, this should now be good to go. Thanks, @EtDu!

@rekmarks rekmarks merged commit bef5bee into master Aug 10, 2020
@rekmarks rekmarks deleted the mobile-rpc branch August 10, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BboyAkers BboyAkers BboyAkers left review comments

@rekmarks rekmarks rekmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EtDu @BboyAkers @rekmarks