fixup! make selected account the first account returned

MetaMask · Dec 10, 2019 · 0c04a87 · 0c04a87
1 parent 79e8975
commit 0c04a87
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/app/scripts/controllers/preferences.js b/app/scripts/controllers/preferences.js
@@ -406,7 +406,7 @@ class PreferencesController {
 
     const { selectedAddressHistory } = this.store.getState()
 
-    // spare us the state update if it's unnecessary
+    // only update state if it's necessary
     if (selectedAddressHistory[origin] !== address) {
       selectedAddressHistory[origin] = address
       this.store.updateState({ selectedAddressHistory })

diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -558,6 +558,7 @@ module.exports = class MetamaskController extends EventEmitter {
       removePermissionsFor: permissionsController.removePermissionsFor.bind(permissionsController),
       updatePermittedAccounts: nodeify(permissionsController.updatePermittedAccounts, permissionsController),
       legacyExposeAccounts: nodeify(permissionsController.legacyExposeAccounts, permissionsController),
+      handleNewAccountSelected: nodeify(permissionsController.handleNewAccountSelected, permissionsController),
 
       getRequestAccountTabIds: (cb) => cb(null, this.getRequestAccountTabIds()),
       getOpenMetamaskTabsIds: (cb) => cb(null, this.getOpenMetamaskTabsIds()),

diff --git a/ui/app/selectors/permissions.js b/ui/app/selectors/permissions.js
@@ -7,8 +7,8 @@ import {
 
 /**
  * TODO:LoginPerSite
- * There are permission gains here once `domain.permissions` is converted
- * to key:value instead of an array.
+ * There are performance gains here once `domain.permissions` is converted
+ * to key:value instead of an array. (requires update to rpc-cap)
  */
 
 const permissionsSelector = (state, origin) => {