Skip to content

Commit

Permalink
Backport "Don't updatePendingTxs outside of block updates (#8445)" (#…
Browse files Browse the repository at this point in the history
…8474)

Backport #8445 to v7.7.9. Original commit description:

* Don't updatePendingTxs outside of block updates

Refs #8377

Reverts 507397f (#5431)

* Check for new block data on unlock

Co-authored-by: Whymarrh Whitby <whymarrh.whitby@gmail.com>
  • Loading branch information
Gudahtt and whymarrh authored Apr 30, 2020
1 parent 2d36d42 commit 14d4c10
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion app/scripts/controllers/transactions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -724,7 +724,6 @@ class TransactionController extends EventEmitter {
Updates the memStore in transaction controller
*/
_updateMemstore () {
this.pendingTxTracker.updatePendingTxs()
const unapprovedTxs = this.txStateManager.getUnapprovedTxList()
const selectedAddressTxList = this.txStateManager.getFilteredTxList({
from: this.getSelectedAddress(),
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/metamask-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ module.exports = class MetamaskController extends EventEmitter {
}

await this.preferencesController.syncAddresses(accounts)
await this.txController.pendingTxTracker.updatePendingTxs()
await this.blockTracker.checkForLatestBlock()

try {
const threeBoxSyncingAllowed = this.threeBoxController.getThreeBoxSyncingState()
Expand Down

0 comments on commit 14d4c10

Please sign in to comment.