Skip to content

Commit

Permalink
Use common test build during CI
Browse files Browse the repository at this point in the history
Previously both e2e test jobs were running `test:build`. Now there is a
separate job that runs `test:build` that runs before each e2e test job,
so that `test:build` is only run once instead of twice.
  • Loading branch information
Gudahtt committed Sep 19, 2019
1 parent 48bf2f8 commit 2ecac6b
Showing 1 changed file with 22 additions and 4 deletions.
26 changes: 22 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ workflows:
- prep-build:
requires:
- prep-deps
- prep-build-test:
requires:
- prep-deps
# - prep-docs:
# requires:
# - prep-deps
Expand All @@ -25,10 +28,10 @@ workflows:
- prep-deps
- test-e2e-chrome:
requires:
- prep-deps
- prep-build-test
- test-e2e-firefox:
requires:
- prep-deps
- prep-build-test
- test-unit:
requires:
- prep-deps
Expand Down Expand Up @@ -122,6 +125,21 @@ jobs:
- dist
- builds

prep-build-test:
docker:
- image: circleci/node:10.16-browsers
steps:
- checkout
- attach_workspace:
at: .
- run:
name: Build extension for testing
command: yarn build:test
- persist_to_workspace:
root: .
paths:
- dist

prep-docs:
docker:
- image: circleci/node:10.16-browsers
Expand Down Expand Up @@ -187,7 +205,7 @@ jobs:
at: .
- run:
name: test:e2e:chrome
command: yarn build:test && yarn test:e2e:chrome
command: yarn test:e2e:chrome
no_output_timeout: 20m
- store_artifacts:
path: test-artifacts
Expand All @@ -205,7 +223,7 @@ jobs:
at: .
- run:
name: test:e2e:firefox
command: yarn build:test && yarn test:e2e:firefox
command: yarn test:e2e:firefox
no_output_timeout: 20m
- store_artifacts:
path: test-artifacts
Expand Down

0 comments on commit 2ecac6b

Please sign in to comment.