Skip to content

Commit

Permalink
fix(deps): @keystonehq/metamask-airgapped-keyring@^0.13.1->^0.14.1 (#…
Browse files Browse the repository at this point in the history 
…27952)

## **Description**

Bump `@keystonehq/metamask-airgapped-kayring`, removing dependency on
legacy `@metamask/obs-store`.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27952?quickstart=1)

## **Related issues**

## **Manual testing steps**
- Test basic HW wallet flow with Keystone wallet

## **Screenshots/Recordings**

### **Before**

### **After**

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
@legobeat
legobeat authored Oct 23, 2024
1 parent a91c2d0 commit 5668333
Show file tree
Hide file tree
Showing 6 changed files with 58 additions and 313 deletions.
84 changes: 14 additions & 70 deletions lavamoat/browserify/beta/policy.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,9 @@
"@ethereumjs/tx": true,
"@keystonehq/bc-ur-registry-eth": true,
"@keystonehq/metamask-airgapped-keyring>@keystonehq/base-eth-keyring": true,
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store": true,
"@keystonehq/metamask-airgapped-keyring>rlp": true,
"@metamask/obs-store": true,
"browserify>buffer": true,
"ethereumjs-util>rlp": true,
"uuid": true,
"webpack>events": true
}
Expand All @@ -382,65 +382,18 @@
"@ethereumjs/tx": true,
"@ethereumjs/tx>@ethereumjs/util": true,
"@keystonehq/bc-ur-registry-eth": true,
"@keystonehq/metamask-airgapped-keyring>@keystonehq/base-eth-keyring>rlp": true,
"@metamask/eth-trezor-keyring>hdkey": true,
"browserify>buffer": true,
"eth-lattice-keyring>rlp": true,
"uuid": true
}
},
"@keystonehq/metamask-airgapped-keyring>@keystonehq/base-eth-keyring>rlp": {
"globals": {
"TextEncoder": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store": {
"packages": {
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>@metamask/safe-event-emitter": true,
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2": true,
"stream-browserify": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>@metamask/safe-event-emitter": {
"globals": {
"setTimeout": true
},
"packages": {
"webpack>events": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2": {
"packages": {
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream": true,
"browserify>util": true,
"process": true,
"watchify>xtend": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream": {
"packages": {
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>isarray": true,
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>safe-buffer": true,
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>string_decoder": true,
"browserify>browser-resolve": true,
"browserify>timers-browserify": true,
"process": true,
"pumpify>inherits": true,
"readable-stream-2>core-util-is": true,
"readable-stream-2>process-nextick-args": true,
"readable-stream>util-deprecate": true,
"webpack>events": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>safe-buffer": {
"@keystonehq/metamask-airgapped-keyring>rlp": {
"packages": {
"bn.js": true,
"browserify>buffer": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>string_decoder": {
"packages": {
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>safe-buffer": true
}
},
"@lavamoat/lavadome-react": {
"globals": {
"Document.prototype": true,
Expand Down Expand Up @@ -1409,12 +1362,18 @@
"@metamask/keyring-controller>ethereumjs-wallet>ethereumjs-util": {
"packages": {
"@metamask/keyring-controller>ethereumjs-wallet>ethereum-cryptography": true,
"@metamask/keyring-controller>ethereumjs-wallet>ethereumjs-util>rlp": true,
"bn.js": true,
"browserify>assert": true,
"browserify>buffer": true,
"browserify>insert-module-globals>is-buffer": true,
"ethereumjs-util>create-hash": true,
"ethereumjs-util>rlp": true
"ethereumjs-util>create-hash": true
}
},
"@metamask/keyring-controller>ethereumjs-wallet>ethereumjs-util>rlp": {
"packages": {
"bn.js": true,
"browserify>buffer": true
}
},
"@metamask/logging-controller": {
Expand Down Expand Up @@ -4087,9 +4046,9 @@
"eth-lattice-keyring>gridplus-sdk>bignumber.js": true,
"eth-lattice-keyring>gridplus-sdk>bitwise": true,
"eth-lattice-keyring>gridplus-sdk>borc": true,
"eth-lattice-keyring>gridplus-sdk>rlp": true,
"eth-lattice-keyring>gridplus-sdk>secp256k1": true,
"eth-lattice-keyring>gridplus-sdk>uuid": true,
"eth-lattice-keyring>rlp": true,
"ethereumjs-util>ethereum-cryptography>bs58check": true,
"ethers>@ethersproject/sha2>hash.js": true,
"lodash": true
Expand Down Expand Up @@ -4143,11 +4102,6 @@
"location": true
}
},
"eth-lattice-keyring>gridplus-sdk>rlp": {
"globals": {
"TextEncoder": true
}
},
"eth-lattice-keyring>gridplus-sdk>secp256k1": {
"packages": {
"@metamask/ppom-validator>elliptic": true
Expand Down Expand Up @@ -5362,16 +5316,6 @@
"webpack>events": true
}
},
"readable-stream-2>core-util-is": {
"packages": {
"browserify>insert-module-globals>is-buffer": true
}
},
"readable-stream-2>process-nextick-args": {
"packages": {
"process": true
}
},
"readable-stream>util-deprecate": {
"globals": {
"console.trace": true,
Expand Down
84 changes: 14 additions & 70 deletions lavamoat/browserify/flask/policy.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -370,9 +370,9 @@
"@ethereumjs/tx": true,
"@keystonehq/bc-ur-registry-eth": true,
"@keystonehq/metamask-airgapped-keyring>@keystonehq/base-eth-keyring": true,
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store": true,
"@keystonehq/metamask-airgapped-keyring>rlp": true,
"@metamask/obs-store": true,
"browserify>buffer": true,
"ethereumjs-util>rlp": true,
"uuid": true,
"webpack>events": true
}
Expand All @@ -382,65 +382,18 @@
"@ethereumjs/tx": true,
"@ethereumjs/tx>@ethereumjs/util": true,
"@keystonehq/bc-ur-registry-eth": true,
"@keystonehq/metamask-airgapped-keyring>@keystonehq/base-eth-keyring>rlp": true,
"@metamask/eth-trezor-keyring>hdkey": true,
"browserify>buffer": true,
"eth-lattice-keyring>rlp": true,
"uuid": true
}
},
"@keystonehq/metamask-airgapped-keyring>@keystonehq/base-eth-keyring>rlp": {
"globals": {
"TextEncoder": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store": {
"packages": {
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>@metamask/safe-event-emitter": true,
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2": true,
"stream-browserify": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>@metamask/safe-event-emitter": {
"globals": {
"setTimeout": true
},
"packages": {
"webpack>events": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2": {
"packages": {
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream": true,
"browserify>util": true,
"process": true,
"watchify>xtend": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream": {
"packages": {
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>isarray": true,
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>safe-buffer": true,
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>string_decoder": true,
"browserify>browser-resolve": true,
"browserify>timers-browserify": true,
"process": true,
"pumpify>inherits": true,
"readable-stream-2>core-util-is": true,
"readable-stream-2>process-nextick-args": true,
"readable-stream>util-deprecate": true,
"webpack>events": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>safe-buffer": {
"@keystonehq/metamask-airgapped-keyring>rlp": {
"packages": {
"bn.js": true,
"browserify>buffer": true
}
},
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>string_decoder": {
"packages": {
"@keystonehq/metamask-airgapped-keyring>@metamask/obs-store>through2>readable-stream>safe-buffer": true
}
},
"@lavamoat/lavadome-react": {
"globals": {
"Document.prototype": true,
Expand Down Expand Up @@ -1409,12 +1362,18 @@
"@metamask/keyring-controller>ethereumjs-wallet>ethereumjs-util": {
"packages": {
"@metamask/keyring-controller>ethereumjs-wallet>ethereum-cryptography": true,
"@metamask/keyring-controller>ethereumjs-wallet>ethereumjs-util>rlp": true,
"bn.js": true,
"browserify>assert": true,
"browserify>buffer": true,
"browserify>insert-module-globals>is-buffer": true,
"ethereumjs-util>create-hash": true,
"ethereumjs-util>rlp": true
"ethereumjs-util>create-hash": true
}
},
"@metamask/keyring-controller>ethereumjs-wallet>ethereumjs-util>rlp": {
"packages": {
"bn.js": true,
"browserify>buffer": true
}
},
"@metamask/logging-controller": {
Expand Down Expand Up @@ -4087,9 +4046,9 @@
"eth-lattice-keyring>gridplus-sdk>bignumber.js": true,
"eth-lattice-keyring>gridplus-sdk>bitwise": true,
"eth-lattice-keyring>gridplus-sdk>borc": true,
"eth-lattice-keyring>gridplus-sdk>rlp": true,
"eth-lattice-keyring>gridplus-sdk>secp256k1": true,
"eth-lattice-keyring>gridplus-sdk>uuid": true,
"eth-lattice-keyring>rlp": true,
"ethereumjs-util>ethereum-cryptography>bs58check": true,
"ethers>@ethersproject/sha2>hash.js": true,
"lodash": true
Expand Down Expand Up @@ -4143,11 +4102,6 @@
"location": true
}
},
"eth-lattice-keyring>gridplus-sdk>rlp": {
"globals": {
"TextEncoder": true
}
},
"eth-lattice-keyring>gridplus-sdk>secp256k1": {
"packages": {
"@metamask/ppom-validator>elliptic": true
Expand Down Expand Up @@ -5362,16 +5316,6 @@
"webpack>events": true
}
},
"readable-stream-2>core-util-is": {
"packages": {
"browserify>insert-module-globals>is-buffer": true
}
},
"readable-stream-2>process-nextick-args": {
"packages": {
"process": true
}
},
"readable-stream>util-deprecate": {
"globals": {
"console.trace": true,
Expand Down
Loading

0 comments on commit 5668333

Please sign in to comment.