fix: fix PR comments

MetaMask · Jul 2, 2024 · 5a480a3 · 5a480a3
1 parent 77d5006
commit 5a480a3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/ui/components/multichain/asset-picker-amount/asset-picker-modal/Asset.tsx b/ui/components/multichain/asset-picker-amount/asset-picker-modal/Asset.tsx
@@ -55,7 +55,7 @@ export default function Asset({
       secondary={formattedFiat}
       title={title}
       tooltipText={tooltipText}
-      hidePercentage
+      showPercentage={false}
     />
   );
 }
diff --git a/ui/components/multichain/asset-picker-amount/asset-picker-modal/AssetList.tsx b/ui/components/multichain/asset-picker-amount/asset-picker-modal/AssetList.tsx
@@ -134,7 +134,6 @@ export default function AssetList({
               display={Display.Block}
               flexWrap={FlexWrap.NoWrap}
               alignItems={AlignItems.center}
-              style={{ cursor: 'pointer' }}
             >
               <Box marginInlineStart={2}>
                 {token.type === AssetType.native ? (
@@ -162,7 +161,7 @@ export default function AssetList({
                     tokenImage={token.image}
                     isNativeCurrency
                     isOriginalTokenSymbol={isOriginalNativeSymbol}
-                    hidePercentage
+                    showPercentage={false}
                   />
                 ) : (
                   <AssetComponent

diff --git a/ui/components/multichain/token-list-item/token-list-item.js b/ui/components/multichain/token-list-item/token-list-item.js
@@ -76,7 +76,7 @@ export const TokenListItem = ({
   isNativeCurrency = false,
   isStakeable = false,
   address = null,
-  hidePercentage = false,
+  showPercentage = true,
 }) => {
   const t = useI18nContext();
   const isEvm = useSelector(getMultichainIsEvm);
@@ -87,7 +87,7 @@ export const TokenListItem = ({
 
   // Scam warning
   const showScamWarning =
-    isNativeCurrency && !isOriginalTokenSymbol && !hidePercentage;
+    isNativeCurrency && !isOriginalTokenSymbol && showPercentage;
 
   const dispatch = useDispatch();
   const [showScamWarningModal, setShowScamWarningModal] = useState(false);
@@ -160,7 +160,7 @@ export const TokenListItem = ({
   // Used for badge icon
   const currentNetwork = useSelector(getMultichainCurrentNetwork);
   const testNetworkBackgroundColor = useSelector(getTestNetworkBackgroundColor);
-  const tokenMainTitleToDisplay = hidePercentage ? tokenSymbol : tokenTitle;
+  const tokenMainTitleToDisplay = showPercentage ? tokenTitle : tokenSymbol;
 
   return (
     <Box
@@ -283,11 +283,11 @@ export const TokenListItem = ({
                 </Text>
               )}
 
-              {isEvm && hidePercentage ? (
+              {isEvm && !showPercentage ? (
                 <Text
                   variant={TextVariant.bodyMd}
                   color={TextColor.textAlternative}
-                  data-testid="multichain-token-list-item-token-name" //
+                  data-testid="multichain-token-list-item-token-name"
                   ellipsis
                 >
                   {tokenTitle}
@@ -454,7 +454,7 @@ TokenListItem.propTypes = {
   address: PropTypes.string,
 
   /**
-   * hidePercentage represents if the increase decrease percentage will be hidden
+   * showPercentage represents if the increase decrease percentage will be hidden
    */
-  hidePercentage: PropTypes.bool,
+  showPercentage: PropTypes.bool,
 };
diff --git a/ui/hooks/useTokenFiatAmount.js b/ui/hooks/useTokenFiatAmount.js
@@ -49,7 +49,6 @@ export function useTokenFiatAmount(
   const tokenExchangeRate =
     overrides.exchangeRate ??
     (contractExchangeTokenKey && mergedRates[contractExchangeTokenKey]);
-
   const formattedFiat = useMemo(
     () =>
       getTokenFiatAmount(