Skip to content

Commit

Permalink
Change copy from estimated to network fee
Browse files Browse the repository at this point in the history
  • Loading branch information
pedronfigueiredo committed Sep 3, 2024
1 parent 594d580 commit 5c92007
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions app/_locales/en/messages.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions test/e2e/tests/confirmations/transactions/shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -226,13 +226,13 @@ export async function toggleAdvancedDetails(driver: Driver) {
}

export async function assertAdvancedGasDetails(driver: Driver) {
await driver.waitForSelector({ css: 'p', text: 'Estimated fee' });
await driver.waitForSelector({ css: 'p', text: 'Network fee' });
await driver.waitForSelector({ css: 'p', text: 'Speed' });
await driver.waitForSelector({ css: 'p', text: 'Max fee' });
}

export async function assertAdvancedGasDetailsWithL2Breakdown(driver: Driver) {
await driver.waitForSelector({ css: 'p', text: 'Estimated fee' });
await driver.waitForSelector({ css: 'p', text: 'Network fee' });
await driver.waitForSelector({ css: 'p', text: 'L1 fee' });
await driver.waitForSelector({ css: 'p', text: 'L2 fee' });
await driver.waitForSelector({ css: 'p', text: 'Speed' });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ describe('Contract Interaction Confirmation', () => {

const editGasFeesRow =
within(gasFeesSection).getByTestId('edit-gas-fees-row');
expect(editGasFeesRow).toHaveTextContent('Estimated fee');
expect(editGasFeesRow).toHaveTextContent('Network fee');

const firstGasField = within(editGasFeesRow).getByTestId('first-gas-field');
expect(firstGasField).toHaveTextContent('0.0084 ETH');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const EditGasFeesRow = ({
alertKey={RowAlertKey.EstimatedFee}
ownerId={transactionMeta.id}
data-testid="edit-gas-fees-row"
label={t('estimatedFee')}
label={t('networkFee')}
tooltip={t('estimatedFeeTooltip')}
>
<Box
Expand Down

0 comments on commit 5c92007

Please sign in to comment.