Fix lint, unit and integration tests related to a/b test code

MetaMask · Sep 19, 2019 · 983e04b · 983e04b
1 parent a647b6d
commit 983e04b
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 12 deletions.
diff --git a/app/scripts/background.js b/app/scripts/background.js
@@ -442,7 +442,7 @@ function triggerUi () {
  * Opens a new browser tab for user confirmation
  */
 function triggerUiInNewTab () {
-  extension.tabs.query({ active: true }, tabs => {
+  extension.tabs.query({ active: true }, () => {
     const tabIdsArray = Object.keys(openMetamaskTabsIDs)
     if (tabIdsArray.length) {
       extension.tabs.update(parseInt(tabIdsArray[0], 10), { 'active': true }, () => {

diff --git a/development/states/confirm-sig-requests.json b/development/states/confirm-sig-requests.json
@@ -23,6 +23,9 @@
         "name": "Send Account 4"
       }
     },
+    "abTests": {
+      "fullScreenVsPopup": "control"
+    },
     "cachedBalances": {},
     "conversionRate": 1200.88200327,
     "conversionDate": 1489013762,

diff --git a/development/states/currency-localization.json b/development/states/currency-localization.json
@@ -23,6 +23,9 @@
         "name": "Send Account 4"
       }
     },
+    "abTests": {
+      "fullScreenVsPopup": "control"
+    },
     "cachedBalances": {},
     "unapprovedTxs": {},
     "conversionRate": 19855,

diff --git a/development/states/tx-list-items.json b/development/states/tx-list-items.json
@@ -23,6 +23,9 @@
         "name": "Send Account 4"
       }
     },
+    "abTests": {
+      "fullScreenVsPopup": "control"
+    },
     "cachedBalances": {},
     "currentCurrency": "USD",
     "conversionRate": 1200.88200327,

diff --git a/test/unit/migrations/037-test.js b/test/unit/migrations/037-test.js
@@ -28,17 +28,7 @@ describe('migration #37', () => {
 
     migration37.migrate(oldStorage)
       .then((newStorage) => {
-        try {
-          assert.deepEqual(newStorage.data.ABTestController, {
-            'fullScreenVsPopup': 'control',
-          })
-        } catch (e) {
-          assert.deepEqual(newStorage.data.ABTestController, {
-            abTests: {
-              'fullScreenVsPopup': 'fullScreen',
-            },
-          })
-        }
+        assert(newStorage.data.ABTestController.abTests.fullScreenVsPopup.match(/control|fullScreen/))
         done()
       })
       .catch(done)