-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bump
@metamask/assets-controllers
to ^13.0.0 (#20916)
## Explanation Needed to help get us closer to phasing out a single globally selected network. Bumps `@metamask/assets-controllers` to ^13.0.0 and passes networkClientId arg to newly updated `TokenController.addToken()`, `TokenController.addTokens()`, and `TokenController.watchAsset()`. Adopts changes in other asset-related controllers * Fixes MetaMask/MetaMask-planning#1020 * See MetaMask/core#1676 ## Screenshots/Screencaps None. Should be no changes apparent to user. ## Manual Testing Steps ### Via Dapp API * Visit any [coingecko token page](https://www.coingecko.com/en/coins/ethereum-name-service) * On a supported built-in network (switch to mainnet) * Click the metamask icon on the page * Tooltip says: "Add to MetaMask" * Accept * Verify the token shows up in wallet UI ### Via Wallet UI * From wallet ui * Import new token * Fill in token details * Use `0xc18360217d8f7ab5e7c516566761ea12ce7f9d72` contract address for ENS * Verify the token shows up in wallet UI ## Pre-merge author checklist - [x] I've clearly explained: - [x] What problem this PR is solving - [x] How this problem was solved - [x] How reviewers can test my changes - [x] Sufficient automated test coverage has been added ## Pre-merge reviewer checklist - [ ] Manual testing (e.g. pull and build branch, run in browser, test code being changed) - [ ] PR is linked to the appropriate GitHub issue - [ ] **IF** this PR fixes a bug in the release milestone, add this PR to the release milestone If further QA is required (e.g. new feature, complex testing steps, large refactor), add the `Extension QA Board` label. In this case, a QA Engineer approval will be be required. --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
- Loading branch information
1 parent
0139b99
commit f814c41
Showing
18 changed files
with
442 additions
and
226 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.