[Design quality]: Update white Ethereum logo for assets and networks from white SVG to purple SVG #26936
Labels
area-design
Design bug (previously known as papercuts - ask Hilary for more detail)
regression-prod-11.16.15
Regression bug that was found in production in release 11.16.15
Sev3-low
Low severity; minimal to no impact upon users
team-assets
type-bug
Comments
amandaye0h
added
type-bug
area-design
metamaskbot
added
the
regression-prod-11.16.15
anaamolnar
added
Sev3-low
7 tasks
gambinish
added a commit
that referenced
this issue
Sep 20, 2024
## **Description** Updates ETH token and network icon to purple for better visibility on light mode. [](https://codespaces.new/MetaMask/metamask-extension/pull/27295?quickstart=1) ## **Related issues** Issue: #26936 Jira: https://consensyssoftware.atlassian.net/browse/MMASSETS-378 ## **Manual testing steps** Check to see that Ethereum token and network logos are the purple one @amandaye0h the [figma](https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Portfolio-View?node-id=4602-89483&node-type=frame&m=dev) design logo had a white border. I modified the svg to remove this border, but can you please check that it looks alright to you? ## **Screenshots/Recordings** ### **Before** <img width="357" alt="Screenshot 2024-09-19 at 3 37 49 PM" src="https://github.com/user-attachments/assets/7646d086-b140-4360-999c-94f4f0d64250"> <img width="358" alt="Screenshot 2024-09-19 at 3 38 12 PM" src="https://github.com/user-attachments/assets/08265151-7bff-46ef-8fd8-0e9c64c45e19"> ### **After** <img width="361" alt="Screenshot 2024-09-19 at 3 33 55 PM" src="https://github.com/user-attachments/assets/5adf82a0-23eb-419e-9fb6-c8d438ab1937"> <img width="358" alt="Screenshot 2024-09-19 at 3 34 23 PM" src="https://github.com/user-attachments/assets/7a31dc5b-ba88-4052-a643-2822f7dfa01d"> <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/27295?quickstart=1){kind=link}
|
Resolved here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The white logo is inconsistent with other wallet/dApps and with Mobile/Portfolio. Updating the logo to purple improves the cohesion and visuals.
Expected behavior
eth_logo.svgin this folder is updated to this purple svgScreenshots/Recordings
Figma link
Steps to reproduce
Error messages or log output
No response
Detection stage
In production (default)
Version
11.16.15
Build type
None
Browser
Brave
Operating system
MacOS
Hardware wallet
No response
Additional context
Ping @amandaye0h for context
Severity
No response
The text was updated successfully, but these errors were encountered: