Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ERC1155 does not have 'edit' button on confirmations page #26955

Closed
ejwessel opened this issue Sep 5, 2024 · 1 comment · Fixed by #27004
Closed

[Bug]: ERC1155 does not have 'edit' button on confirmations page #26955

ejwessel opened this issue Sep 5, 2024 · 1 comment · Fixed by #27004
Assignees
@jpuri
Labels
regression-prod-12.0.0 Regression bug that was found in production in release 12.0.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@ejwessel
Copy link
Contributor

ejwessel commented Sep 5, 2024

Describe the bug

ERC721s have an 'edit' button on the confirmation page
ERC1155 does not have an 'edit' button on the confirmation page

Expected behavior

ERC1155 to have an 'edit' button on the confirmation page

Screenshots/Recordings

Screenshot 2024-09-05 at 15 21 40 Screenshot 2024-09-05 at 15 21 55

Steps to reproduce

  1. click send
  2. select account
  3. select NFT asset
  4. select ERC721/ERC1155
  5. click 'continue'
  6. verify there is or is not an 'edit' button for ERC1155

Error messages or log output

No response

Detection stage

In production (default)

Version

12.0.0 - 12.0.6

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Sep 5, 2024
@ejwessel ejwessel added Sev2-normal Normal severity; minor loss of service or inconvenience. team-bridge regression-prod-12.0.0 Regression bug that was found in production in release 12.0.0 labels Sep 5, 2024
@ejwessel ejwessel self-assigned this Sep 6, 2024
@ejwessel ejwessel added team-confirmations Push issues to confirmations team and removed team-bridge labels Sep 6, 2024
@ejwessel ejwessel removed their assignment Sep 6, 2024
@jpuri jpuri self-assigned this Sep 10, 2024
@jpuri jpuri mentioned this issue Sep 10, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 12, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 12, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 29, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on issue. Adding release label release-12.5.0 on issue, as issue is linked to PR #27004 which has this release label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
regression-prod-12.0.0 Regression bug that was found in production in release 12.0.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 release-12.6.0 Issue or pull request that will be included in release 12.6.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: edit button on confirmation page for send ERC-1155 token MetaMask/metamask-extension
3 participants
@jpuri @ejwessel @metamaskbot