-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: edit button on confirmation page for send ERC-1155 token #27004
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -148,6 +148,14 @@ export default function ConfirmTokenTransactionSwitch({ transaction }) { | |||
decimals={decimals} | |||
image={tokenImage} | |||
tokenAddress={tokenAddress} | |||
onEdit={async ({ txData }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, it's a legacy pattern in the file but should we define this once as a handleNftEdit
somewhere to avoid the duplication with the other paths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid getting into cleanup as this code is soon going to go away anyways,
…extension into erc_1155_sendedit_fix
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #27004 +/- ##
===========================================
- Coverage 70.15% 70.14% -0.01%
===========================================
Files 1425 1425
Lines 49653 49661 +8
Branches 13891 13892 +1
===========================================
Hits 34833 34833
- Misses 14820 14828 +8 ☔ View full report in Codecov by Sentry. |
Builds ready [f2b1391]
Page Load Metrics (1572 ± 146 ms)
Bundle size diffs
|
'Edit' button on the Send screen s displayed for ERC1155 and ERC721 tokens: 1155_721.mov |
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
Description
Fix for bug that edit button was not visible on send ERC-1155 page.
Related issues
Fixes: #26955
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist