Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit button on confirmation page for send ERC-1155 token #27004

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 10, 2024

Description

Fix for bug that edit button was not visible on send ERC-1155 page.

Related issues

Fixes: #26955

Manual testing steps

  1. Send an ERC-1155
  2. Ensure that edit button is present on confirm send page

Screenshots/Recordings

Screenshot 2024-09-10 at 10 16 18 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added the team-confirmations Push issues to confirmations team label Sep 10, 2024
@jpuri jpuri requested a review from a team as a code owner September 10, 2024 04:52
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matthewwalsh0
matthewwalsh0 previously approved these changes Sep 10, 2024
@@ -148,6 +148,14 @@ export default function ConfirmTokenTransactionSwitch({ transaction }) {
decimals={decimals}
image={tokenImage}
tokenAddress={tokenAddress}
onEdit={async ({ txData }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, it's a legacy pattern in the file but should we define this once as a handleNftEdit somewhere to avoid the duplication with the other paths?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid getting into cleanup as this code is soon going to go away anyways,

Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.14%. Comparing base (7dc6362) to head (f2b1391).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...rm-transaction/confirm-token-transaction-switch.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #27004      +/-   ##
===========================================
- Coverage    70.15%   70.14%   -0.01%     
===========================================
  Files         1425     1425              
  Lines        49653    49661       +8     
  Branches     13891    13892       +1     
===========================================
  Hits         34833    34833              
- Misses       14820    14828       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [f2b1391]
Page Load Metrics (1572 ± 146 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint38626571501394189
domContentLoaded130226451559305147
load133826551572303146
domInteractive15432363
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 167 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya
Copy link
Contributor

sleepytanya commented Sep 11, 2024

'Edit' button on the Send screen s displayed for ERC1155 and ERC721 tokens:

1155_721.mov

@jpuri jpuri merged commit 36f96ae into develop Sep 12, 2024
78 checks passed
@jpuri jpuri deleted the erc_1155_sendedit_fix branch September 12, 2024 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 12, 2024
@metamaskbot metamaskbot added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 29, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ERC1155 does not have 'edit' button on confirmations page
4 participants