Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fiat values displayed for test networks tokens despite having 'Show conversion on test networks' disabled #28594

Closed
sleepytanya opened this issue Nov 21, 2024 · 0 comments · Fixed by #28601
Closed

[Bug]: Fiat values displayed for test networks tokens despite having 'Show conversion on test networks' disabled #28594

sleepytanya opened this issue Nov 21, 2024 · 0 comments · Fixed by #28601
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets type-bug

Comments

@sleepytanya
Copy link
Contributor

Describe the bug

Fiat values displayed for test networks tokens despite having 'Show conversion on test networks' disabled

Expected behavior

Screenshots/Recordings

conversion.mov

Steps to reproduce

  1. Switch to a test network
  2. Disable 'Show conversion on test networks'

Error messages or log output

No response

Detection stage

On the development branch

Version

qa-5 build

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@sleepytanya sleepytanya added type-bug team-assets portfolio-view Used for PRs and issues related to Q4 2024 portfolio view labels Nov 21, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 21, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 21, 2024
@sahar-fehri sahar-fehri mentioned this issue Nov 21, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 21, 2024
@sahar-fehri
fix: fix test networks display for portfolio view (#28601)
08cc205 
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR fixes the display in the asset page and in the main token list
when the price checker setting is off

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28601?quickstart=1)

## **Related issues**

Fixes: #28594

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**


https://github.com/user-attachments/assets/a1213b6a-3f23-49f5-be15-a0b369b9016e


<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Nov 21, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Nov 21, 2024
@metamaskbot metamaskbot added the release-12.9.0 Issue or pull request that will be included in release 12.9.0 label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-assets type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix test networks display for portfolio view MetaMask/metamask-extension
2 participants
@metamaskbot @sleepytanya