Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all addresses EIP-55 compliant #3514

Closed
fulldecent opened this issue Mar 12, 2018 · 12 comments
Closed

Make all addresses EIP-55 compliant #3514

fulldecent opened this issue Mar 12, 2018 · 12 comments
Assignees
Labels
area-UI Relating to the user interface. type-enhancement

Comments

@fulldecent
Copy link

fulldecent commented Mar 12, 2018

Bounty: make all instances of account addresses in MetaMask compliant with EIP-55. Many instances of account addresses already are compliant, and successful completion of this bounty will require finding and updating all non-compliant addresses throughout the extension.


The correct mixed-case address is shown (truncated, but shown) on the main MetaMask screen.

But the address shown on the QR screen is all lower case.

@tmashuang
Copy link
Contributor

Almost all the QR address I have seen, they're checksum. I do not know the key difference between checksum and not, but from what I understand checksum is not really enforced, and can be either way. I believe it still would better to standardize the QR code for users/service that require it.

@2-am-zzz 2-am-zzz added the area-UI Relating to the user interface. label Mar 13, 2018
@ConnorMac
Copy link

ConnorMac commented Aug 16, 2018

Not sure if this is relevant here or in it's own issue but the address copied to the clipboard from the extension widget is not complaint either but if you open the tab version it displays/copies the correct checksum address.

@fulldecent
Copy link
Author

Confirmed still broken in latest version.

The screenshot below encodes the QR text:

ethereum:0xd859d7d8603d2dab768d679eeec25930c8fc59c1

screen shot 2018-09-11 at 11 22 47 pm

@bdresser bdresser changed the title QR screen shows address that is not EIP-55 compliant Make all addresses EIP-55 compliant Sep 26, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.25 ETH (54.98 USD @ $219.91/ETH) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Sep 27, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 6 months, 2 weeks from now.
Please review their action plans below:

1) bakaoh has started work.

I will do some search on the codebase. It should take less than a day

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.25 ETH (54.51 USD @ $218.04/ETH) has been submitted by:

  1. @bakaoh

@bdresser please take a look at the submitted work:


@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.25 ETH (56.66 USD @ $226.66/ETH) attached to this issue has been approved & issued to @bakaoh.

@fulldecent
Copy link
Author

@whymarrh please reopen

Confirmed broken in latest version.

screen shot 2018-11-10 at 12 48 13 pm

@fulldecent
Copy link
Author

Confirmed broken in latest version 5.3.1

screen shot 2019-01-21 at 11 23 43 pm copy

@whymarrh
Copy link
Contributor

@fulldecent apologies for the delay, I'll make sure this gets fixed in the next release!

@fulldecent
Copy link
Author

No worries. Just doing my duty here to prevent the issue from going stale!

@whymarrh
Copy link
Contributor

This has been fixed on develop and is slated for the next v6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. type-enhancement
Projects
None yet
Development

No branches or pull requests

8 participants