-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all addresses EIP-55 compliant #3514
Comments
Almost all the QR address I have seen, they're checksum. I do not know the key difference between checksum and not, but from what I understand checksum is not really enforced, and can be either way. I believe it still would better to standardize the QR code for users/service that require it. |
Not sure if this is relevant here or in it's own issue but the address copied to the clipboard from the extension widget is not complaint either but if you open the tab version it displays/copies the correct checksum address. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.25 ETH (54.98 USD @ $219.91/ETH) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 6 months, 2 weeks from now. 1) bakaoh has started work. I will do some search on the codebase. It should take less than a day Learn more on the Gitcoin Issue Details page. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 0.25 ETH (54.51 USD @ $218.04/ETH) has been submitted by: @bdresser please take a look at the submitted work:
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done The funding of 0.25 ETH (56.66 USD @ $226.66/ETH) attached to this issue has been approved & issued to @bakaoh.
|
@whymarrh please reopen Confirmed broken in latest version. |
@fulldecent apologies for the delay, I'll make sure this gets fixed in the next release! |
No worries. Just doing my duty here to prevent the issue from going stale! |
This has been fixed on |
Bounty: make all instances of account addresses in MetaMask compliant with EIP-55. Many instances of account addresses already are compliant, and successful completion of this bounty will require finding and updating all non-compliant addresses throughout the extension.
The correct mixed-case address is shown (truncated, but shown) on the main MetaMask screen.
But the address shown on the QR screen is all lower case.
The text was updated successfully, but these errors were encountered: