Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all addresses EIP-55 compliant #5379

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Make all addresses EIP-55 compliant #5379

merged 2 commits into from
Oct 10, 2018

Conversation

bakaoh
Copy link
Contributor

@bakaoh bakaoh commented Sep 27, 2018 •
edited
Loading

Fix: #3514

  • Address from QR image
  • Copy contract address token dropdown menu
  • SenderToRecipient component
  • ToAutoComplete compoment

@bakaoh bakaoh changed the title [WIP] Make all addresses EIP-55 compliant Make all addresses EIP-55 compliant Sep 27, 2018
@gitcoinbot gitcoinbot mentioned this pull request Sep 27, 2018
Closed
@bdresser
Copy link
Contributor

@bakaoh on the confirmation screen, when I copy one of the addresses up top by clicking the sender or recipient, it's still lowercase
screen shot 2018-09-27 at 12 53 32 pm

on the "transaction detail view" (when I click on a submitted tx) the addresses are shown and copied lowercase
screen shot 2018-09-27 at 12 52 18 pm

might be a few more..

@bakaoh
Copy link
Contributor Author

bakaoh commented Oct 2, 2018

@bdresser -- i fixed it, i guess that all

@tmashuang
Copy link
Contributor

https://github.com/MetaMask/metamask-extension/blob/develop/ui/app/components/send/to-autocomplete/to-autocomplete.js#L106

Found on more.

@bakaoh
Copy link
Contributor Author

bakaoh commented Oct 3, 2018

thanks @tmashuang, fixed it

@whymarrh
Copy link
Contributor

whymarrh commented Oct 3, 2018

@bakaoh mind rebasing this on the latest develop to pull in the e2e test fixes? Once this has a green build we can review+merge.

@bakaoh bakaoh force-pushed the issue3514 branch 2 times, most recently from eea6482 to e3f1eb0 Compare October 4, 2018 01:49
@bakaoh
Copy link
Contributor Author

bakaoh commented Oct 8, 2018

@whymarrh -- i rebased it but there're still e2e test failed

@whymarrh
Copy link
Contributor

whymarrh commented Oct 8, 2018

@bakaoh I'll take a look, thanks

whymarrh
whymarrh approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bakaoh, I've fixed up the build with ea6b102

@whymarrh whymarrh merged commit 63c61c5 into MetaMask:develop Oct 10, 2018
Bunjin pushed a commit that referenced this pull request Nov 6, 2018
@bakaoh @Bunjin
Make all addresses EIP-55 compliant (#5379)
c6b97bd 
* Make all addresses EIP-55 compliant

* Checksum autocompleted address but not during input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@alextsg alextsg Awaiting requested review from alextsg

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bakaoh @bdresser @tmashuang @whymarrh