Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to specify the symbol other than ETH and hide currency conversion #4804

Closed
radamosch opened this issue Jul 15, 2018 · 5 comments
Closed

Comments

@radamosch
Copy link

When connected to private or other networks than ETH, it's not currently possible to set the symbol or avoid default denomination in ETH for currency conversion.

While you guys contemplate the ecumenical & security & political matters around network selection in other issues this simple and flexible proposal will mean MM is usable on other networks with a little edit by users.

  1. Allow user to self specify the symbol for the currency from "ETH" --> whatever
  2. Allow user to choose "none" for currency conversion and hide that if it is not set.

This will avoid confusion and wrong denominations in MM when users are connected to networks that are transferring value in other symbols.

image

image

(If you were feeling really helpful, an autodetect of the symbol / currency would be great)

@SoberKush
Copy link

Please take this guy in consideration. This is useful for a huge portion of MetaMask users and I wonder why it hasn't been implemented yet!

Thanks for posting this @radamosch

@davidzki
Copy link

^^^ This!

@bdresser
Copy link
Contributor

Allow user to choose "none" for currency conversion and hide that if it is not set.

Makes sense - this will also require logic that swaps ETH to the primary currency on the confirm screens (i.e. swap the 1 and the 478.30 below)

We should probably allow users to swap ETH to the primary currency without having to hide the conversion (as described in #4510) and add a toggle in the settings.

screen shot 2018-07-16 at 4 01 32 pm

thoughts @danfinlay @cjeria @alextsg? bounty worthy?

@hackmod
Copy link
Contributor

hackmod commented Jul 18, 2018

basically, already done by PR #4516 and work in progress.

@bdresser
Copy link
Contributor

Allow user to self specify the symbol for the currency from "ETH" --> whatever

This is in production!

Allow user to choose "none" for currency conversion and hide that if it is not set.

Tracking this in #5327 and #4775.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants