-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to specify the symbol other than ETH and hide currency conversion #4804
Comments
Please take this guy in consideration. This is useful for a huge portion of MetaMask users and I wonder why it hasn't been implemented yet! Thanks for posting this @radamosch |
^^^ This! |
Makes sense - this will also require logic that swaps ETH to the primary currency on the confirm screens (i.e. swap the We should probably allow users to swap ETH to the primary currency without having to hide the conversion (as described in #4510) and add a toggle in the settings. thoughts @danfinlay @cjeria @alextsg? bounty worthy? |
basically, already done by PR #4516 and work in progress. |
When connected to private or other networks than ETH, it's not currently possible to set the symbol or avoid default denomination in ETH for currency conversion.
While you guys contemplate the ecumenical & security & political matters around network selection in other issues this simple and flexible proposal will mean MM is usable on other networks with a little edit by users.
This will avoid confusion and wrong denominations in MM when users are connected to networks that are transferring value in other symbols.
(If you were feeling really helpful, an autodetect of the symbol / currency would be great)
The text was updated successfully, but these errors were encountered: