support optional chainId #4516

hackmod · 2018-06-05T23:25:16Z

This is an experimental work (WIP)

Basically this PR is based on the net_version hack (by @turbobits)

Currently, MetaMask get the chainId using net_version rpc call but net_version does not return the real chainId. there are no net_chainid nor eth_chainid rpc call exist. ethereum/go-ethereum#15002

In most case of ethereum variants, chainId != networkId.
This is a quick hack to support optional chainid in the custom Rpc.
experimental ETC support added

Done

fixed custom Rpc form to support optional chainid.
- support both old-ui and new-ui
experimental ETC support added
- basically this is a predefined rpcUrl + chainId
ticker (6/21)
block explorer urls (6/21)
support shapeshift exchange for deposit(6/22)
support testnet faucet (6/23)
- ~~[x] MORDEN testnet added~~
more configurable settings like as "blockExplorerUrl"
- rpcUrl, chainId, blockExplorerUrl, ticker symbol
increased customRpcList size from 2 to 3

ToDo

QA test / fix possible bugs
sanity check rpcUrl
~~[x] FIXME morden api server url~~

need some feed back!

References

Screenshot

shd101wyy · 2018-06-08T21:32:35Z

This pull request is awesome. Thanks a lot. I also have the demand to set the chainId.
Hope the maintainer can review your pull request soon. Good job.

wjmelements · 2018-06-08T22:28:41Z

ui/lib/account-link.js

@@ -18,6 +18,7 @@ module.exports = function (address, network) {
      link = `https://kovan.etherscan.io/address/${address}`
      break
    default:
+      // FIXME


Does GasTracker.io work for this purpose?

yes, would be https://gastracker.io/addr/${address}

wjmelements · 2018-06-08T22:45:56Z

Infura doesn't support ETC, so you would need to provide a default RPC provider or enforce a custom RPC URL for non-Infura networks.

splix · 2018-06-09T18:11:10Z

Does Infura provides something specific for metamask, or standard web3 JSON RPC would work? If later works, there is one at https://web3.gastracker.io

wjmelements · 2018-06-11T02:25:39Z

@splix I believe they would only have to support the RPC methods listed at https://github.com/MetaMask/provider-engine#current-rpc-method-support

Based on this article they may support them.

wjmelements · 2018-06-11T02:36:06Z

old-ui/app/config.js

+    case 'classic':
+      title = 'Current Network'
+      value = 'Ethereum Classic Network'
+      break


Similarly, you could add the ETC Testnet, Morden.

wjmelements · 2018-06-11T02:37:41Z

I'm surprised information about a network is not already centralized in an object. That might be a good refactor, though perhaps outside the scope of this pull request.

kumavis · 2018-06-14T03:34:57Z

Another issue here is showing conversion rate
we're still working on breaking out networks for first class treatment which will enable non-evm blockchains as well, but longer time line

hackmod · 2018-06-09T01:18:57Z

app/scripts/controllers/network/networks.js

+  'blockExplorerTX': 'https://gastracker.io/tx/[[txHash]]',
+  'blockExplorerAddr': 'https://gastracker.io/addr/[[address]]',
+  'service': 'epool.io',
+  'rpcUrl': 'https://mew.epool.io',


like as myetherwallet's app/scripts/nodes.js, the networks.js is the predefined rpcUrl + chainId and more.

hackmod · 2018-06-21T00:15:31Z

screenshot updated, etc.

support block explorer
current price using https://min-api.cryptocompare.com/ (mist method)
etc logo added for beta UI

pyskell · 2018-06-22T14:55:45Z

BUG: Doesn't support sending transaction data.

Tried sending a transaction with: 0x657463206f6e206d6574616d61736b20697320776f726b696e6721

Result:

hackmod · 2018-06-22T15:21:52Z

This is a new UI testing result.

https://gastracker.io/tx/0x44fce132106162045005ee5815bffc0b95a5a8b6845273f4fbda2e5f5d97c7cb

hackmod · 2018-06-22T15:26:17Z

and this is an old-UI test.

https://gastracker.io/tx/0x0c4e26058a4fc2e59431db05a061710a34b333aceb6b804444a3abbd94df35c1

hackmod · 2018-06-27T10:34:21Z

app/scripts/controllers/network/networks.js

+    'blockExplorerAddr': 'https://gastracker.io/addr/[[address]]',
+    'blockExplorerToken': 'https://gastracker.io/token/[[tokenAddress]]/[[address]]',
+    'service': 'Ethereum Commonwealth',
+    'rpcUrl': 'https://etc-geth.0xinfra.com',


~~where can I find api server for the modern testnet?~~

~~https://web3.gastracker.io/morden~~ not correctly work...

hackmod · 2018-06-27T13:18:57Z

app/scripts/controllers/network/networks.js

+    'blockExplorerAddr': 'https://gastracker.io/addr/[[address]]',
+    'blockExplorerToken': 'https://gastracker.io/token/[[tokenAddress]]/[[address]]',
+    'service': 'Gastracker.io',
+    'rpcUrl': 'https://web3.gastracker.io/morden',


https://web3.gastracker.io/morden is not work correctly with MetaMask.
@pyskell // is there any official api-server/block explorer exist for the Morden testnet ?

http://mordenexplorer.ethertrack.io looks good to me.

hackmod · 2018-07-09T19:50:36Z

app/scripts/controllers/network/networks.js

+    'blockExplorerAddr': 'http://mordenexplorer.ethertrack.io/addr/[[address]]',
+    'blockExplorerToken': 'http://mordenexplorer.ethertrack.io/token/[[tokenAddress]]/[[address]]',
+    'service': 'Gastracker.io',
+    'rpcUrl': 'https://etc-geth.0xinfra.com',


FIXME is there any official json rpc api-server/block explorer exist for the Morden testnet ?

Maybe contact the ETC rpc providers about adding support for the testnet. If there isn't a reliable rpc provider for the ETC testnet, don't list it among the supported networks.

@hackmod Remove modern testnet, no one is using ethereum classic testnet for testing purpose. Why do we need the option??

OK. as you already know, this is a quick hack and I'm not much familiar with a react program.
we need more testing to find possible bugs. that's the reason the morden testnet added.

@hackmod I've opened a public rpc endpoint for morden testnet

https://morden.eos-classic.io

Hope we can go forward 👍

And my personal opinion is, we don't have to suppot additional api endpoint for chain-id.

It is needed however we can just hardcode for this case

temporary added morden api server.
but the api server provided by other coin project seems improper to me.

@hackmod Then remove useless morden testnet menu, we've added the endpoint only for this PR merge if you don't need it we will close then

removed and rebased

hackmod · 2018-07-18T16:12:00Z

current screenshot

hackmod · 2018-07-18T22:40:03Z

more configurable options for other ethereum networks or private network

TODO

error handle

* fixed custom Rpc form to support optional chainid * experimental ETC support added

* etc logo added * price info from https://min-api.cryptocompare.com/

* fixup for testnet faucet

hackmod · 2018-07-20T17:36:37Z

increased customRpcList size from 2 to 3

PeterTheOne · 2018-07-25T13:06:57Z

I've tried it with a custom RPC and ticker symbol, seems to work fine, didn't encounter any bugs. keep up the good work!

danfinlay · 2018-07-25T23:02:08Z

This is nice work, but we are not ready to add a bunch of new networks and providers to our menu. If all this PR did was add an optional chainId parameter, we would merge it much more easily, but it instead adds many other things as well, which we are simply not ready to do at this time.

You can read more about our roadmap and vision for supporting multiple networks here:
https://medium.com/metamask/metamasks-vision-for-multiple-network-support-4ffbee9ec64d

hackmod · 2018-07-28T06:42:14Z

bunch of new networks and providers to our menu

@danfinlay
I guess you miss understood this PR

the following screen shot is mere an example. all question mark prefixed items are configured by user by means of settings menu (Custom RPCs).

and the only newly added menu item is ETC.

optional chain_id feature and pre-configured menu(ETC) shares their code, that's why this PR named as "optional chain Id"

anyway, I will separate this issue into several PRs, for example,

optional chain id
more configurable settings for custom Rpc
ETC support

34r7h · 2018-10-13T23:35:19Z

Hey guys and gals. Everything looks good. Anything we still need to help out with to get it shipped with ETC cupport?

bdresser · 2018-10-15T16:49:43Z

@irthos we've moved to #5134 which we'll review this week once we get #4510 merged!

34r7h · 2018-10-15T18:13:01Z

Thank u, big ups!

…

On Mon, Oct 15, 2018 at 12:50 PM bobby dresser ***@***.***> wrote: @irthos <https://github.com/irthos> we've moved to #5134 <#5134> which we'll review this week once we get #4510 <#4510> merged! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4516 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACcpoE4n5f-p7mfT5-dxTj7-rlQA19Sbks5ulLy-gaJpZM4UbwM6> .

hackmod force-pushed the chainid-fix branch from 437d6a8 to 8cdc88c Compare June 6, 2018 00:16

wjmelements reviewed Jun 8, 2018

View reviewed changes

wjmelements changed the base branch from master to develop June 8, 2018 22:38

wjmelements reviewed Jun 11, 2018

View reviewed changes

hackmod commented Jun 14, 2018

View reviewed changes

hackmod force-pushed the chainid-fix branch from 8cdc88c to 4b51759 Compare June 21, 2018 00:06

hackmod force-pushed the chainid-fix branch 4 times, most recently from c3d16ec to 722802f Compare June 22, 2018 04:29

hackmod force-pushed the chainid-fix branch 2 times, most recently from 0a401b8 to 4d02967 Compare June 27, 2018 05:27

hackmod commented Jun 27, 2018

View reviewed changes

hackmod force-pushed the chainid-fix branch from 4d02967 to 5809f22 Compare June 27, 2018 11:12

hackmod commented Jun 27, 2018

View reviewed changes

hackmod force-pushed the chainid-fix branch 3 times, most recently from 1a3c090 to 8d26a69 Compare July 3, 2018 00:50

hackmod force-pushed the chainid-fix branch from 8d26a69 to fd3692b Compare July 8, 2018 18:34

hackmod commented Jul 9, 2018

View reviewed changes

hackmod force-pushed the chainid-fix branch from 253dcc5 to 2f653db Compare July 18, 2018 15:59

hackmod mentioned this pull request Jul 18, 2018

Status request on including ETC mainnet #4753

Closed

hackmod mentioned this pull request Jul 18, 2018

Allow users to specify the symbol other than ETH and hide currency conversion #4804

Closed

hackmod force-pushed the chainid-fix branch from 2f653db to fc89250 Compare July 18, 2018 22:26

hackmod force-pushed the chainid-fix branch from fc89250 to e55b3d9 Compare July 18, 2018 23:38

hackmod added 5 commits July 21, 2018 01:37

support chainid

4873e6f

* fixed custom Rpc form to support optional chainid * experimental ETC support added

update testcase

555a90a

setup settings and use correct ticker / blockexploer URLs

6d908be

* etc logo added * price info from https://min-api.cryptocompare.com/

support shapeshift exchange for deposit

72ded43

* fixup for testnet faucet

customRpc: make explorerUrl, ticker symbol configurable

307ba9d

hackmod force-pushed the chainid-fix branch from e55b3d9 to bb1185b Compare July 20, 2018 16:37

save FrequentRpcList correctly. increse the size of the RpcList

a19718d

hackmod force-pushed the chainid-fix branch from bb1185b to a19718d Compare July 20, 2018 17:01

hackmod mentioned this pull request Jul 20, 2018

Metamask integration ellaism/meta#45

Closed

MetaMask deleted a comment Jul 24, 2018

MetaMask deleted a comment from wjmelements Jul 24, 2018

danfinlay closed this Jul 25, 2018

hackmod mentioned this pull request Aug 1, 2018

Initial multi-chain support (aka. optional chainid fix) #4932

Closed

8 tasks

This was referenced Aug 23, 2018

Optional Chain_id w/o Native ETC Support #5130

Closed

optional chainId (extracted from #4932) #5134

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support optional chainId #4516

support optional chainId #4516

hackmod commented Jun 5, 2018 •

edited

Loading

shd101wyy commented Jun 8, 2018

wjmelements Jun 8, 2018

splix Jun 9, 2018

wjmelements commented Jun 8, 2018

splix commented Jun 9, 2018

wjmelements commented Jun 11, 2018

wjmelements Jun 11, 2018

wjmelements commented Jun 11, 2018

kumavis commented Jun 14, 2018

hackmod Jun 9, 2018

hackmod commented Jun 21, 2018 •

edited

Loading

pyskell commented Jun 22, 2018

hackmod commented Jun 22, 2018

hackmod commented Jun 22, 2018 •

edited

Loading

hackmod Jun 27, 2018 •

edited

Loading

hackmod Jun 27, 2018 •

edited

Loading

hackmod Jul 9, 2018 •

edited

Loading

wjmelements Jul 9, 2018

ghost Jul 10, 2018

hackmod Jul 11, 2018

ghost Jul 17, 2018 •

edited by ghost

Loading

ghost Jul 17, 2018

hackmod Jul 17, 2018

ghost Jul 17, 2018

hackmod Jul 18, 2018

hackmod commented Jul 18, 2018

hackmod commented Jul 18, 2018 •

edited

Loading

hackmod commented Jul 20, 2018

PeterTheOne commented Jul 25, 2018

danfinlay commented Jul 25, 2018

hackmod commented Jul 28, 2018 •

edited

Loading

34r7h commented Oct 13, 2018

bdresser commented Oct 15, 2018

34r7h commented Oct 15, 2018 via email

support optional chainId #4516

support optional chainId #4516

Conversation

hackmod commented Jun 5, 2018 • edited Loading

Done

ToDo

need some feed back!

References

Screenshot

shd101wyy commented Jun 8, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wjmelements commented Jun 8, 2018

splix commented Jun 9, 2018

wjmelements commented Jun 11, 2018

Choose a reason for hiding this comment

wjmelements commented Jun 11, 2018

kumavis commented Jun 14, 2018

Choose a reason for hiding this comment

hackmod commented Jun 21, 2018 • edited Loading

pyskell commented Jun 22, 2018

hackmod commented Jun 22, 2018

hackmod commented Jun 22, 2018 • edited Loading

hackmod Jun 27, 2018 • edited Loading

Choose a reason for hiding this comment

hackmod Jun 27, 2018 • edited Loading

Choose a reason for hiding this comment

hackmod Jul 9, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost Jul 17, 2018 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hackmod commented Jul 18, 2018

hackmod commented Jul 18, 2018 • edited Loading

TODO

hackmod commented Jul 20, 2018

PeterTheOne commented Jul 25, 2018

danfinlay commented Jul 25, 2018

hackmod commented Jul 28, 2018 • edited Loading

34r7h commented Oct 13, 2018

bdresser commented Oct 15, 2018

34r7h commented Oct 15, 2018 via email

hackmod commented Jun 5, 2018 •

edited

Loading

hackmod commented Jun 21, 2018 •

edited

Loading

hackmod commented Jun 22, 2018 •

edited

Loading

hackmod Jun 27, 2018 •

edited

Loading

hackmod Jun 27, 2018 •

edited

Loading

hackmod Jul 9, 2018 •

edited

Loading

ghost Jul 17, 2018 •

edited by ghost

Loading

hackmod commented Jul 18, 2018 •

edited

Loading

hackmod commented Jul 28, 2018 •

edited

Loading