verify-locale-string.js fails when using a locale option #5457
Comments
|
Just tried with node v8.11.3 and I've got the same error. The fix proposed in Bunjin@d63a77e works also under node v8.11.3 |
|
@Bunjin feel free to open a PR! |
|
@bdresser Sure, I want to :) I was just waiting to fully test the french locale first and make sure everything is working properly. |
whymarrh
pushed a commit
that referenced
this issue
Oct 9, 2018
* french locales: fix typos and improve wording * french locales: more fixes and rewording * fixed typo * fixed typo * added missing translations * fixed alphabetical order * fixed alphabetical order * added missing translations for FR * fixed verify-locale-strings.js * fixed indentation * fixed indentation * updated french locale * updated changelog with changes logs * a few fixes after receiving comments, mostly Caps removing and adding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running node verify-locale-string.js returns an error when using a locale option
e.g.
node verify-locale-string.js frbut it works without a locale option
develop branch running on node v9.11.1 on ubuntu 16.04
commit:
26e4f87
seems to be related to the {} in line 23 and 33 (and maybe my node version ? )
Fixed in commit in my fork :
Bunjin@d63a77e
The text was updated successfully, but these errors were encountered: