Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications appear at the bottom of Tx List #7460

Closed
tmashuang opened this issue Nov 18, 2019 · 1 comment · Fixed by #7461
Closed

Notifications appear at the bottom of Tx List #7460

tmashuang opened this issue Nov 18, 2019 · 1 comment · Fixed by #7461

Comments

@tmashuang
Copy link
Contributor

tmashuang commented Nov 18, 2019 •
edited
Loading

Currently, the Multiple Notification component appears at the bottom of the Tx List. For users with more than two pending transactions or three confirmed transaction, the notification will not show until scrolling to the bottom.

This prevents showing important information from being showing on first view.

multiple-notifications
@tmashuang tmashuang mentioned this issue Nov 18, 2019
Merged
@tmashuang
Copy link
Contributor Author

Upon further investigation, it seems that the CSS file for this is not properly setting.

metamask-extension/ui/app/components/app/multiple-notifications/index.scss

Line 2 in b3833b1

.home-notification-wrapper--show-first {

Gudahtt added a commit that referenced this issue Nov 18, 2019
@Gudahtt
Import styles for showing multiple notifications
273ec7b 
The styles for the multi-notification component on the home screen were
accidentally removed while resolving a merge conflict in #6891.

Fixes #7460
@Gudahtt Gudahtt mentioned this issue Nov 18, 2019
Merged
@tmashuang tmashuang mentioned this issue Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tmashuang