Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum Firefox version to v68 #10195

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 15, 2021

Firefox v68 is the previous Extended Support Release. We are increasing this because our current minimum version doesn't support async iterators, so some of our dependencies cause the extension to crash.

Our metrics show that usage of Firefox versions older than this is quite low (under 0.7% of Firefox users in the past month). These older versions are also very behind on security updates. Using the Extended Support Release also makes it easier for us to test the minimum version, and ensure our extension remains compatible with it.

Relates to #6805

Firefox v68 is the _previous_ Extended Support Release. We are
increasing this because our current minimum version doesn't support
async iterators, so some of our dependencies cause the extension to
crash.

Our metrics show that usage of Firefox versions older than this is
quite low (under 0.7% of Firefox users in the past month). These older
versions are also _very behind_ on security updates. Using the Extended
Support Release also makes it easier for us to test the minimum
version, and ensure our extension remains compatible with it.

Relates to #6805
@Gudahtt Gudahtt requested a review from a team as a code owner January 15, 2021 15:28
@Gudahtt Gudahtt requested a review from darkwing January 15, 2021 15:28
@metamaskbot
Copy link
Collaborator

Builds ready [c08c5a1]
Page Load Metrics (805 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint309070147
domContentLoaded431101780314067
load432102080514067
domInteractive431101780314067

@darkwing darkwing merged commit 408586a into develop Jan 21, 2021
@darkwing darkwing deleted the increase-firefox-minimum-version branch January 21, 2021 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants