Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build-time code exclusion using code fencing #12060

Merged
merged 30 commits into from
Sep 14, 2021
Merged

Add build-time code exclusion using code fencing #12060

merged 30 commits into from
Sep 14, 2021

Commits on Sep 10, 2021

  1. Initial code fencing transform implementation

    @rekmarks
    rekmarks committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    6d9512e View commit details
    Browse the repository at this point in the history

  2. Rename some stuff

    @rekmarks
    rekmarks committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    779974a View commit details
    Browse the repository at this point in the history

  3. Concatenate file buffers before applying transform

    @rekmarks
    rekmarks committed Sep 10, 2021
    1 Configuration menu
    Copy the full SHA
    6f97fa6 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Begin adding tests

    @rekmarks
    rekmarks committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    ac3d520 View commit details
    Browse the repository at this point in the history

  2. Complete tests, reconfigure Jest

    @rekmarks
    rekmarks committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    3e7fbdb View commit details
    Browse the repository at this point in the history

  3. Rename fileName parameter to filePath

    @rekmarks
    rekmarks committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    6cdb3a8 View commit details
    Browse the repository at this point in the history

  4. Lint transformed files, init lint tests

    @rekmarks
    rekmarks committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    f6126d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. Finish transformed linting tests

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    28c649d View commit details
    Browse the repository at this point in the history

  2. Add spaced-comment marker for fences

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    a90fb76 View commit details
    Browse the repository at this point in the history

  3. Add build system arg for toggling fence linting

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    999250c View commit details
    Browse the repository at this point in the history

  4. Replace through2 with a Transform implementation

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    20bccdd View commit details
    Browse the repository at this point in the history

  5. Default shouldLintFenceFiles to false for dev builds

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    2622421 View commit details
    Browse the repository at this point in the history

  6. Fix spaced-comment config

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    c41078a View commit details
    Browse the repository at this point in the history

  7. Update LavaMoat policy

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    a950ea2 View commit details
    Browse the repository at this point in the history

  8. fixup! Update LavaMoat policy

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    09ca404 View commit details
    Browse the repository at this point in the history

  9. Check that the linter is called correctly in tests

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    f74378d View commit details
    Browse the repository at this point in the history

  10. Add transform function docstrings

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    5bd2a12 View commit details
    Browse the repository at this point in the history

  11. Add some directive test cases

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    bde0241 View commit details
    Browse the repository at this point in the history

  12. Forbid empty fences

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    ae4ecde View commit details
    Browse the repository at this point in the history

  13. Add documentation, handle some parsing edge cases

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    b7545fe View commit details
    Browse the repository at this point in the history

  14. Remove linting

    @rekmarks
    rekmarks committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    ff246dd View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Tweak a test

    @rekmarks
    rekmarks committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    b0c42ec View commit details
    Browse the repository at this point in the history

  2. Stop using 'key in object'

    @rekmarks
    rekmarks committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    efd8cd3 View commit details
    Browse the repository at this point in the history

  3. Address review feedback

    @rekmarks
    rekmarks committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    0828289 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Fix SC2048 violation

    @rekmarks
    rekmarks committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    073f7cf View commit details
    Browse the repository at this point in the history

  2. Update development/build/transforms/remove-fenced-code.js

    @rekmarks
    rekmarks authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    dfadb27 View commit details
    Browse the repository at this point in the history

  3. Update development/build/transforms/remove-fenced-code.js

    @rekmarks
    rekmarks authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    ce15bf2 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    @rekmarks @Gudahtt
    rekmarks and Gudahtt authored Sep 14, 2021
    Configuration menu
    Copy the full SHA
    474ec02 View commit details
    Browse the repository at this point in the history

  5. Fix test scripts

    @rekmarks
    rekmarks committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    662f5ae View commit details
    Browse the repository at this point in the history

  6. Fix tests and some bugs

    @rekmarks
    rekmarks committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    892a0a1 View commit details
    Browse the repository at this point in the history