Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire up priority fee range in new gas modal #13044

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Wire up priority fee range in new gas modal #13044

merged 2 commits into from
Dec 17, 2021

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Dec 10, 2021

Use the priorityFeeRange property which is now available in the gas
fee estimate data.

References #12473.

Manual testing steps:

  • Open .metamaskrc and set EIP_1559_V2 to 1.
  • Go to Send.
  • Enter an address, an amount, and press Next.
  • Click on the "Market" button.
  • Look at the bottom row of the modal. You should see a base fee section, a priority fee section, and a colored slider. The priority fee section should update as new estimates come in.

Screen Shot 2021-12-09 at 5 07 25 PM

@mcmire mcmire requested a review from a team as a code owner December 10, 2021 00:10
@mcmire mcmire requested a review from hmalik88 December 10, 2021 00:10
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mcmire
Wire up priority fee range in new gas modal
c87250f 
Use the `priorityFeeRange` property which is now available in the gas
fee estimate data.
mcmire
mcmire commented Dec 10, 2021
View reviewed changes
ui/components/app/edit-gas-fee-popover/network-statistics/network-statistics.js
<I18nValue messageKey="priorityFee" />
</span>
</div>
<LatestPriorityFeeField />
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to replace the network-statistics__info__field instead of what was inside the field, which I noticed StatusSlider was doing. If this makes sense, I will come back and fix StatusSlider so it's consistent with this.

jpuri
jpuri previously approved these changes Dec 10, 2021
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [c87250f]
Page Load Metrics (963 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641024396422203
domContentLoaded91010289613215
load91810289633015
domInteractive91010289613215

highlights:

storybook

@metamaskbot
Copy link
Collaborator

Builds ready [852fb07]
Page Load Metrics (1167 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint731352601512246
domContentLoaded9601526116612862
load9601526116712861
domInteractive9601526116612862

highlights:

storybook

@jpuri
Copy link
Contributor

jpuri commented Dec 10, 2021

Fixes: #12473

@mcmire mcmire merged commit d990cb5 into develop Dec 17, 2021
@mcmire mcmire deleted the wire-up-priority-fee-range branch December 17, 2021 23:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

@jpuri jpuri jpuri approved these changes

@darkwing darkwing darkwing approved these changes

@hmalik88 hmalik88 Awaiting requested review from hmalik88 hmalik88 is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcmire @metamaskbot @jpuri @darkwing @NiranjanaBinoy