Add TypeScript to the linting process #13495

mcmire · 2022-02-02T22:30:17Z

This commit allows developers to write TypeScript files and lint them
(either via a language server in their editor of choice or through the
yarn lint command).

The new TypeScript configuration as well as the updated ESLint
configuration not only includes support for parsing TypeScript files,
but also provides some compatibility between JavaScript and TypeScript.
That is, it makes it possible for a TypeScript file that imports a
JavaScript file or a JavaScript file that imports a TypeScript file to
be linted.

Note that this commit does not integrate TypeScript into the build
system yet, so we cannot start converting files to TypeScript and
pushing them to the repo until that final step is complete.

Manual testing steps:

Check out this branch locally.
Run git cherry-pick 4bde1eb1d0bf0e84d76f83bb0bb065cfc1f45e58.
- This commit (which is disconnected from this branch) converts two files to TypeScript, ui/helpers/utils/tx-helper.ts and ui/helpers/utils/storage-helpers.ts. Both of these files have dependents which are JavaScript files, and ui/helpers/utils/tx-helper.ts has dependencies which are JavaScript files.
Run yarn setup.
Open ui/helpers/utils/storage-helpers.ts in your editor. Remove the semicolon from the first line; your editor should tell you (via ESLint) that this is invalid.
Now open ui/index.js. This file imports tx-helper.ts. Mouse over txHelper in the import txHelper line; you should see proper types for this function which come from the TypeScript file.
Run yarn lint. All files should pass.

github-actions · 2022-02-02T22:30:31Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2022-02-04T00:41:53Z

Builds ready [1658fe3]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1267 ± 29 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	1326	566	524	252
		domContentLoaded	1101	1347	1267	60	29
		load	1101	1348	1267	60	29
		domInteractive	1101	1347	1267	60	29

.eslintrc.js

mcmire · 2022-02-04T00:10:12Z

.eslintrc.js

+        // <https://github.com/alexgorbatchev/eslint-import-resolver-typescript>
+        'import/no-unresolved': 'error',
+
+        // Disabled due to incompatibility with Record<string, unknown>.


These settings are copied from the ESLint config in controllers: https://github.com/MetaMask/controllers/blob/81bcbae1c4abe71a9b07819606e155a33ec4a6b4/.eslintrc.js#L29-L43. We should probably integrate them into our shared config.

mcmire · 2022-02-04T00:14:16Z

.gitignore

@@ -46,3 +46,6 @@ notes.txt
 .nyc_output

 .metamaskrc
+
+# TypeScript
+tsout/


See note about tsout in tsconfig.json.

jsconfig.json

mcmire · 2022-02-04T05:01:25Z

patches/typescript+4.4.4.patch

+     return to.concat(ar || Array.prototype.slice.call(from));
+ };
+ var __assign = (this && this.__assign) || function () {
+-    __assign = Object.assign || function(t) {


These changes to the typescript package were motivated by failures I was getting from LavaMoat when attempting to generate LavaMoat policy files for the build system (via yarn lavamoat:auto. That said, this commit is concerned with adding TypeScript to ESLint, not the build system, so why are these changes necessary?

Because, as I learned, the build system actually runs ESLint. As I've been going through the codebase, I've occasionally come across sections of code that are surrounded with ///: BEGIN:ONLY_INCLUDE_IN and ///: END:ONLY_INCLUDE_IN (for example, account-menu.component.js. I've always wondered about them, and now I know that they get removed during a step in the build process. After this transform is applied to a file, that file is linted.

So, when running yarn lavamoat:auto, LavaMoat sees these files and follows the path to eslint.config.js, then follows the path to the typescript package. Why does it trip up on this file in particular?

One of the things that LavaMoat, or more accurately the lockdown function in SES, does is to protect against unwanted and unexpected modifications of global objects, such as Object.prototype. Admittedly I am unable to explain much beyond this, but you can learn more about this function here. The lockdown function, as it uses Object.freeze to lock down objects, suffers from a "mistake" in the ECMAScript spec where a property inherited from a frozen object is itself frozen. Plain objects inherit constructor from Object.prototype, so if Object.prototype is frozen, this code will not work:

const foo = {}; foo["constructor"] = "bar";

But that is what is happening in this file. The ts.textToKeywordObj object maps names of keywords in TypeScript to token ids that represent those keywords (defined elsewhere), and one of the keywords in TypeScript is constructor. For some reason, whatever ended up producing this file (probably TypeScript itself) defined this object essentially like this:

ts.textToKeywordObj = ( _a = { /* ... */ }, _a["constructor"] = 133, // ... _a );

That doesn't work, so one of the changes made here is to clean up the definition of this object.

The other change is to the __assign function, which you can see here. One of the ways that __assign is used is to make a textToToken variable on line 9904. This looks something like:

var textToToken = __assign( {}, ts.textToKeywordObj, { "{": 18 /* OpenBraceToken */, "}": 19 /* CloseBraceToken */, // ... } )

As you can see here, __assign defaults to Object.assign here if it exists, or otherwise falls back to a polyfill of Object.assign. Whether or not the polyfill is used, __assign creates a new object by iterating over the given objects and manually copying their keys and values to the new object by setting them directly on the new object. This will attempt to set constructor on the new object again, which as we've seen, is not allowed. So this change fixes __assign by using Object.defineProperty to set properties instead of direct assignment.

mcmire · 2022-02-04T05:06:16Z

tsconfig.json

+    "inlineSources": true,
+    "isolatedModules": true,
+    "jsx": "react",
+    "lib": ["dom", "es2020"],


These settings were copied from the tsconfig.json in controllers but then adjusted to account for JSX as well as browser globals. ES2020 was chosen because Node v14 supports it, so that should make it less surprising for developers who wish to be able to write frontend code in a similar fashion as Node code. (The JavaScript that TypeScript generates will end up getting processed by Babel in the build system so we should be safe here.)

mcmire · 2022-02-04T05:07:50Z

tsconfig.json

+    "moduleResolution": "node",
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "outDir": "tsout",


This setting will not end up getting used by the build system. This is only here so that if you want to debug an issue you're seeing with TypeScript, you can say yarn tsc --project . like this and inspect the generated JavaScript output. tsout will be gitignored.

mcmire · 2022-02-09T18:40:16Z

There were some good suggestions provided in the walkthrough call today on how we should add TS to ESLint in a way that doesn't decrease performance. I'm going to move this back into draft status as this will prompt some changes. Update: these changes have been made.

metamaskbot · 2022-02-15T06:50:42Z

Builds ready [5ffcffe]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1162 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	1288	341	385	185
		domContentLoaded	1036	1494	1162	131	63
		load	1036	1494	1162	131	63
		domInteractive	1036	1494	1162	131	63

mcmire · 2022-02-15T22:30:59Z

patches/eslint-import-resolver-typescript+2.5.0.patch

+     '.ts',
+     '.tsx',
+-    '.d.ts'
+-], Object.keys(require.extensions)), [


When I opened this file, I got an ESLint warning that require.extensions was deprecated. When I ran yarn lavamoat:auto, then require.extensions was undefined. I am not sure what exactly the correct fix here is, but I don't think we need to make this complicated — the list of extensions we want to support are JavaScript and TypeScript, so we don't need to use require.extensions.

mcmire · 2022-02-16T19:01:05Z

patches/@keystonehq+bc-ur-registry+0.4.4.patch

@@ -0,0 +1,1830 @@
+diff --git a/node_modules/@keystonehq/bc-ur-registry/src/Bytes.ts b/node_modules/@keystonehq/bc-ur-registry/src/Bytes.ts


The @keystonehq/bc-ur-registry package contains TypeScript files in its distributed form. This is not necessary or recommended for TypeScript-compatible libraries (rather, it is enough to publish type definition files). The issue for this is logged here: KeystoneHQ/ur-registry#13. In the meantime, as our code works fine presently without any TypeScript files, we do not need these in order to use this library. This makes the new tsc step in yarn lint pass.

So, to make sure I understand correctly, this code is not used by the extension, but we need this patch to get lint passing?

Sorry maybe my explanation was confusing. We do use this package (it looks like a component that is involved with the QR code stuff imports @keystonehq/bc-ur-registry-eth, which imports @keystonehq/bc-ur-registry). However, the way this package has been bundled and published to NPM is incorrect as it includes TypeScript files.

mcmire · 2022-02-16T19:01:37Z

patches/await-semaphore+0.1.3.patch

@@ -0,0 +1,68 @@
+diff --git a/node_modules/await-semaphore/index.ts b/node_modules/await-semaphore/index.ts


The await-semaphore package contains TypeScript files in its distributed form. This is not necessary or recommended for TypeScript-compatible libraries (rather, it is enough to publish type definition files). The issue for this is logged here: notenoughneon/await-semaphore#6. In the meantime, as our code works fine presently without any TypeScript files, we do not need these in order to use this library. This makes the new tsc step in yarn lint pass.

(I notice there is a thumbs-up on this issue from Mark so I'm curious if we ran into this issue in controllers or mobile?)

So, to make sure I understand correctly, this code is not used by the extension, but we need this patch to get lint passing?

We do use this package (it looks like at the top of MetamaskController). However, the way this package has been bundled and published to NPM is incorrect as it includes TypeScript files.

It looks like we're removing the Semaphore class that Mutex extends in this patch. Does this not break when this.createVaultMutex.acquire(); runs in the MetamaskController?

So, we aren't removing all the code in await-semaphore. You can see here that the version of this package published to NPM includes both JavaScript and TypeScript files. We are just removing the TypeScript files, but we are still using the JavaScript files. So this.createVaultMutex.acquire(); should still work as before.

metamaskbot · 2022-02-16T19:36:43Z

Builds ready [f6008cb]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1084 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	353	154	127	61
		domContentLoaded	990	1647	1083	136	65
		load	990	1648	1084	136	65
		domInteractive	990	1647	1083	136	65

metamaskbot · 2022-03-01T23:08:36Z

Builds ready [93d8f12]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1117 ± 29 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	1199	569	461	221
		domContentLoaded	1027	1257	1115	58	28
		load	1027	1257	1117	60	29
		domInteractive	1027	1257	1115	58	28

metamaskbot · 2022-03-02T17:35:12Z

Builds ready [0d855e4]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1211 ± 36 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	1261	647	534	256
		domContentLoaded	1064	1360	1208	76	36
		load	1064	1360	1211	75	36
		domInteractive	1064	1360	1208	76	36

This commit allows developers to write TypeScript files and lint them (either via a language server in their editor of choice or through the `yarn lint` command). The new TypeScript configuration as well as the updated ESLint configuration not only includes support for parsing TypeScript files, but also provides some compatibility between JavaScript and TypeScript. That is, it makes it possible for a TypeScript file that imports a JavaScript file or a JavaScript file that imports a TypeScript file to be linted. Note that this commit does not integrate TypeScript into the build system yet, so we cannot start converting files to TypeScript and pushing them to the repo until that final step is complete.

darkwing

These changes look great to me, and thank you so much for all the code commenting! Hugely useful!

metamaskbot · 2022-03-04T18:42:38Z

Builds ready [de92b97]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1438 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	1540	464	451	217
		domContentLoaded	1246	1754	1436	104	50
		load	1246	1765	1438	105	50
		domInteractive	1246	1754	1436	104	50

digiwand

Super! 🙌 I had one question about one of the patches and some other optional comments.

Thanks for walking through this PR with me last Friday and enlightening me on TypeScript + patching files in relation to our codebase.

Looking forward to removing the following paths from the excluded list someday too:

    "**/*.test.js",
    "**/*.test.ts",
    "**/*.test.tsx",
    ".storybook/**/*",

digiwand · 2022-03-08T01:52:31Z

.eslintrc.js

+        'import/named': 'off',
+        'import/namespace': 'off',
+        'import/default': 'off',
+        'import/no-named-as-default-member': 'off',


I think we can remove this since the rule lives in typescript-compat.js. Is there a reason we are keeping this here?

No, although arguably it shouldn't be in typescript-compat.js as it shouldn't apply to every kind of file, just TypeScript files. Removed in cec7044.

.eslintrc.typescript-compat.js

digiwand · 2022-03-08T03:29:50Z

tsconfig.json

+    "outDir": "tsout",
+    "rootDir": ".",
+    "sourceMap": true,
+    "strict": true


Taking a quick peek of some other tsconfig.json file configs for chrome-extensions:

https://github.com/chibat/chrome-extension-typescript-starter/blob/master/tsconfig.json

https://betterprogramming.pub/creating-chrome-extensions-with-typescript-914873467b65

I think you might have explained this last Friday, but I forgot. Sorry if this was the case. Why are we not including

"module": "commonjs", "target": "es6",

again?

"noEmitOnError" - might be something to consider later. This holds back from generating js files to outDir if there are ts errors found

I think you might have explained this last Friday, but I forgot. Sorry if this was the case. Why are we not including

"module": "commonjs", "target": "es6",

We are, but I admit it's a bit hidden: that is being done by the "extends": "@tsconfig/node14/tsconfig.json" line. You can see the source for that here.

"noEmitOnError" - might be something to consider later. This holds back from generating js files to outDir if there are ts errors found

I don't mind adding it now! Added in 0ccb400

digiwand · 2022-03-08T03:45:38Z

patches/await-semaphore+0.1.3.patch

@@ -0,0 +1,68 @@
+diff --git a/node_modules/await-semaphore/index.ts b/node_modules/await-semaphore/index.ts


It looks like we're removing the Semaphore class that Mutex extends in this patch. Does this not break when this.createVaultMutex.acquire(); runs in the MetamaskController?

mcmire · 2022-03-08T20:41:05Z

@digiwand Hopefully I've addressed all your concerns! Would you mind taking another look?

digiwand

Look good! Thank you.

Last question I have: Is it possible to add comments to patch files? I think it would be helpful to provide context for each patch.

mcmire · 2022-03-08T22:56:10Z

@digiwand

Is it possible to add comments to patch files? I think it would be helpful to provide context for each patch.

We can't add comments to file that we delete, but we can add them to those that we change (a patch file changes the files in question, so the comments get added to those files). I've done this in 8908c09.

This reverts commit d575ecf.

digiwand

Great work! Thank you for this! 🎉

mcmire · 2022-03-09T22:08:19Z

@darkwing May I get one more approval?

metamaskbot · 2022-03-21T17:01:32Z

Builds ready [f55c164]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1319 ± 57 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	75	1350	150	276	132
		domContentLoaded	1185	1714	1317	120	57
		load	1185	1714	1319	119	57
		domInteractive	1185	1714	1317	120	57

brad-decker

Looks good to me, and loving learning from @digiwand 's exploration as well and the questions asked. Great work @mcmire and @digiwand thanks for your thorough review and questions.

mcmire added the Team 🌳 label Feb 2, 2022

mcmire force-pushed the add-typescript-to-eslint-config branch from 61890a6 to 5fbe15c Compare February 3, 2022 23:19

mcmire changed the title ~~[WIP] Add TypeScript to ESLint config and linting tasks~~ Add TypeScript to the linting process Feb 3, 2022

mcmire force-pushed the add-typescript-to-eslint-config branch 2 times, most recently from 6b9fe58 to 1658fe3 Compare February 4, 2022 00:06

mcmire commented Feb 4, 2022

View reviewed changes

mcmire marked this pull request as ready for review February 4, 2022 05:08

mcmire requested a review from a team as a code owner February 4, 2022 05:08

mcmire requested review from darkwing and a team and removed request for a team February 4, 2022 05:08

mcmire marked this pull request as draft February 9, 2022 18:40

mcmire force-pushed the refactor-eslint-config branch from 8a2321b to 4b74949 Compare February 15, 2022 06:34

mcmire force-pushed the add-typescript-to-eslint-config branch from 5ffcffe to c4ca8e1 Compare February 15, 2022 22:27

mcmire force-pushed the refactor-eslint-config branch from 4b74949 to c983c6c Compare February 15, 2022 22:28

mcmire force-pushed the add-typescript-to-eslint-config branch from c4ca8e1 to 8842d00 Compare February 15, 2022 22:29

mcmire commented Feb 15, 2022

View reviewed changes

mcmire marked this pull request as ready for review February 15, 2022 22:31

mcmire requested a review from kumavis as a code owner February 15, 2022 22:31

mcmire mentioned this pull request Feb 15, 2022

Add TypeScript to the build system #13489

Merged

mcmire force-pushed the add-typescript-to-eslint-config branch from 8842d00 to c0852fe Compare February 15, 2022 22:43

mcmire mentioned this pull request Feb 15, 2022

Allow customizing order of bify transforms/plugins #13483

Closed

mcmire force-pushed the refactor-eslint-config branch from c983c6c to fd16fdf Compare February 15, 2022 22:46

mcmire force-pushed the add-typescript-to-eslint-config branch from c0852fe to 8d473ee Compare February 15, 2022 22:46

mcmire commented Feb 16, 2022

View reviewed changes

mcmire force-pushed the add-typescript-to-eslint-config branch from 93d8f12 to 0d855e4 Compare March 2, 2022 16:45

mcmire force-pushed the add-typescript-to-eslint-config branch from 0d855e4 to de92b97 Compare March 4, 2022 16:47

darkwing previously approved these changes Mar 4, 2022

View reviewed changes

mcmire added 3 commits March 7, 2022 10:42

Use @link for link

272e921

Remove jsconfig.json as tsconfig.json should suffice

0fd8c7d

No need for includes; add builds/ to exclude

69699c2

mcmire dismissed darkwing’s stale review via 69699c2 March 7, 2022 17:47

digiwand reviewed Mar 8, 2022

View reviewed changes

mcmire added 3 commits March 8, 2022 13:20

Remove duplicate rule config

cec7044

Add noEmitOnError: true

0ccb400

Add some sample files so linting can be tested

d575ecf

digiwand reviewed Mar 8, 2022

View reviewed changes

mcmire added 2 commits March 8, 2022 14:47

Merge branch 'develop' into add-typescript-to-eslint-config

51d578d

Add comments to patches

8908c09

mcmire added 2 commits March 9, 2022 09:58

Revert "Add some sample files so linting can be tested"

00701bd

This reverts commit d575ecf.

Merge branch 'develop' into add-typescript-to-eslint-config

6a381cf

digiwand approved these changes Mar 9, 2022

View reviewed changes

Merge branch 'develop' into add-typescript-to-eslint-config

f55c164

brad-decker approved these changes Mar 21, 2022

View reviewed changes

mcmire merged commit 4447727 into develop Mar 21, 2022

mcmire deleted the add-typescript-to-eslint-config branch March 21, 2022 18:54

github-actions bot locked and limited conversation to collaborators Mar 21, 2022

		@@ -0,0 +1,1830 @@
		diff --git a/node_modules/@keystonehq/bc-ur-registry/src/Bytes.ts b/node_modules/@keystonehq/bc-ur-registry/src/Bytes.ts

		@@ -0,0 +1,68 @@
		diff --git a/node_modules/await-semaphore/index.ts b/node_modules/await-semaphore/index.ts

Add TypeScript to the linting process #13495

Add TypeScript to the linting process #13495

Conversation

mcmire commented Feb 2, 2022 • edited Loading

github-actions bot commented Feb 2, 2022

metamaskbot commented Feb 4, 2022

Choose a reason for hiding this comment

mcmire Feb 4, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcmire Feb 4, 2022 • edited Loading

Choose a reason for hiding this comment

mcmire commented Feb 9, 2022 • edited Loading

metamaskbot commented Feb 15, 2022

mcmire Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcmire Feb 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Feb 16, 2022

metamaskbot commented Mar 1, 2022

metamaskbot commented Mar 2, 2022

darkwing left a comment

Choose a reason for hiding this comment

metamaskbot commented Mar 4, 2022

digiwand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcmire commented Mar 8, 2022

digiwand left a comment

Choose a reason for hiding this comment

mcmire commented Mar 8, 2022

digiwand left a comment

Choose a reason for hiding this comment

mcmire commented Mar 9, 2022

metamaskbot commented Mar 21, 2022

brad-decker left a comment

Choose a reason for hiding this comment

mcmire commented Feb 2, 2022 •

edited

Loading

mcmire Feb 4, 2022 •

edited

Loading

mcmire Feb 4, 2022 •

edited

Loading

mcmire commented Feb 9, 2022 •

edited

Loading

mcmire Feb 15, 2022 •

edited

Loading

mcmire Feb 16, 2022 •

edited

Loading