-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unblock ci: update vuln deps + fix npm registry for snaps firefox #14437
Conversation
fixed upstream caolan/async#1828 (comment) |
removed the patch, keeping the ignored vuln until the vuln is updated |
The yarn.lock file still contains the vulnerable version, you'll need to delete that and regenerate the lock file to update. We also don't need to add async as a direct dependency |
* Use regular NPM registry for snaps on FF * Fix linting * Update app/scripts/metamask-controller.js Co-authored-by: Shane <jonas.shane@gmail.com> Co-authored-by: kumavis <kumavis@users.noreply.github.com> Co-authored-by: Shane <jonas.shane@gmail.com>
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [6ad6dfd]Page Load Metrics (1368 ± 43 ms)
|
note: https://github.com/MetaMask/pm-security/issues/72