Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ENS wildcard and offchain resolution #14526

Closed
wants to merge 12 commits into from

Conversation

makoto
Copy link
Contributor

@makoto makoto commented Apr 25, 2022

Explanation

This PR addresses MetaMask/specifications#9

NOTE: Support for contenthash will be separate PR.

More information

Please read https://medium.com/the-ethereum-name-service/upgrade-ethers-js-to-5-6-1-to-activate-ens-l2-offchain-integration-40ee1a0fdf2a for more deail.

Screenshots/Screencaps

Display forward lookup

Screenshot 2022-04-25 at 16 36 05

Display reverse record (aka primary name)

Screenshot 2022-04-25 at 16 35 48

Manual testing steps

    1. Select testnet (Ropsten/Rinkeby/Goerli network)
    1. Lookup 1.offchainexample.eth to lookup ENS name
    1. Send ETH to 1.offchainexample.eth and check it shows in the transaction log

@makoto makoto requested a review from a team as a code owner April 25, 2022 21:09
@makoto makoto requested a review from jpuri April 25, 2022 21:09
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2022

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

1 out of 2 committers have signed the CLA.
@makoto
@makoto Inoue

GitHub can't find an account for Makoto Inoue.
You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@makoto
Copy link
Contributor Author

makoto commented Apr 27, 2022

I have read the CLA Document and I hereby sign the CLA

@jacobc-eth
Copy link

Hey Makoto, we're discussing this on our side! In the meantime, would you consider submitting a similar PR for MetaMask Mobile? We try to avoid situations where features are only available on one client to the extent possible.

@makoto
Copy link
Contributor Author

makoto commented May 11, 2022

would you consider submitting a similar PR for MetaMask Mobile?

I can give it a try but do your mobile apps also use js so that I can just upgrade ethers.js that does the majority of the support work?

@jacobc-eth
Copy link

@makoto yep, our mobile app is React Native.

@makoto makoto closed this May 16, 2022
@makoto makoto reopened this May 16, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2022
@brad-decker
Copy link
Contributor

Closing in favor of #14675

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants