-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ENS wildcard and offchain resolution #14526
Conversation
CLA Signature Action: Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:
By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository. 1 out of 2 committers have signed the CLA.
|
I have read the CLA Document and I hereby sign the CLA |
Hey Makoto, we're discussing this on our side! In the meantime, would you consider submitting a similar PR for MetaMask Mobile? We try to avoid situations where features are only available on one client to the extent possible. |
I can give it a try but do your mobile apps also use js so that I can just upgrade ethers.js that does the majority of the support work? |
@makoto yep, our mobile app is React Native. |
Closing in favor of #14675 |
Explanation
This PR addresses MetaMask/specifications#9
NOTE: Support for contenthash will be separate PR.
More information
Please read https://medium.com/the-ethereum-name-service/upgrade-ethers-js-to-5-6-1-to-activate-ens-l2-offchain-integration-40ee1a0fdf2a for more deail.
Screenshots/Screencaps
Display forward lookup
Display reverse record (aka primary name)
Manual testing steps