Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ledger support for eth_getEncryptionPublicKey #16716

Closed
wants to merge 6 commits into from
Closed

feat: add ledger support for eth_getEncryptionPublicKey #16716

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fabbe65
feat: add ledger support for eth_getEncryptionPublicKey
justingreenberg Nov 28, 2022
0b98ba7
Merge branch 'develop' into feat/ledger-get-encryption-pubkey
darkwing Nov 29, 2022
562747c
Merge branch 'develop' into feat/ledger-get-encryption-pubkey
justingreenberg Nov 30, 2022
71b96ed
Merge branch 'develop' into feat/ledger-get-encryption-pubkey
justingreenberg Feb 14, 2023
e47d451
Merge branch 'develop' into feat/ledger-get-encryption-pubkey
brad-decker Feb 14, 2023
26a1d62
fix: rebase and sync with develop
justingreenberg Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions app/scripts/metamask-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3310,14 +3310,6 @@ export default class MetamaskController extends EventEmitter {
const keyring = await this.keyringController.getKeyringForAccount(address);

switch (keyring.type) {
case HardwareKeyringTypes.ledger: {
return new Promise((_, reject) => {
reject(
new Error('Ledger does not support eth_getEncryptionPublicKey.'),
);
});
}

case HardwareKeyringTypes.trezor: {
return new Promise((_, reject) => {
reject(
Expand Down
Loading