-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use snaps@0.35.2-flask.1
and snaps@1.0.0-prerelease.1
#19734
Conversation
snaps@0.35.0-flask.1
and snaps@1.0.0-prerelease.1
snaps@0.35.1-flask.1
and snaps@1.0.0-prerelease.1
snaps@0.35.1-flask.1
and snaps@1.0.0-prerelease.1
snaps@0.35.2-flask.1
and snaps@1.0.0-prerelease.1
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore @metamask/providers@11.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be updated once deployment is approved.
Codecov Report
@@ Coverage Diff @@
## develop #19734 +/- ##
===========================================
+ Coverage 69.83% 69.83% +0.01%
===========================================
Files 980 980
Lines 36886 36886
Branches 9890 9891 +1
===========================================
+ Hits 25757 25759 +2
+ Misses 11129 11127 -2
|
Builds ready [8977dd2]
Page Load Metrics (1583 ± 67 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Explanation
Bumps Snaps Flask packages to
0.35.2-flask.1
and handles any breaking changes. This PR also bumps the Snaps stable packages to1.0.0-prerelease.1
, this allows us to remove some temporary mocks that were added for a breaking change that had not been released on the Snaps audit branch.Due to changes in the build output in the Snaps packages this PR also changes some imports slightly and therefore introduces more of the Snaps dependencies in the MetaMask build.