Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use snaps@0.35.2-flask.1 and snaps@1.0.0-prerelease.1 #19734

Merged
merged 11 commits into from
Jun 26, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Jun 23, 2023

Explanation

Bumps Snaps Flask packages to 0.35.2-flask.1 and handles any breaking changes. This PR also bumps the Snaps stable packages to 1.0.0-prerelease.1, this allows us to remove some temporary mocks that were added for a breaking change that had not been released on the Snaps audit branch.

Due to changes in the build output in the Snaps packages this PR also changes some imports slightly and therefore introduces more of the Snaps dependencies in the MetaMask build.

@FrederikBolding FrederikBolding changed the title Use snaps@0.35.0-flask.1 and snaps@1.0.0-prerelease.1 Use snaps@0.35.1-flask.1 and snaps@1.0.0-prerelease.1 Jun 23, 2023
@FrederikBolding FrederikBolding changed the title Use snaps@0.35.1-flask.1 and snaps@1.0.0-prerelease.1 Use snaps@0.35.2-flask.1 and snaps@1.0.0-prerelease.1 Jun 26, 2023
@socket-security
Copy link

socket-security bot commented Jun 26, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/providers@11.0.0, @metamask/snaps-controllers@0.35.2-flask.1, @metamask/snaps-utils@0.35.2-flask.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@FrederikBolding
Copy link
Member Author

@SocketSecurity ignore @metamask/providers@11.0.0
@SocketSecurity ignore @metamask/snaps-controllers@0.35.2-flask.1
@SocketSecurity ignore @metamask/snaps-utils@0.35.2-flask.1

Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be updated once deployment is approved.

builds.yml Outdated Show resolved Hide resolved
builds.yml Outdated Show resolved Hide resolved
test/env.js Outdated Show resolved Hide resolved
@FrederikBolding FrederikBolding marked this pull request as ready for review June 26, 2023 10:59
@FrederikBolding FrederikBolding requested review from a team as code owners June 26, 2023 10:59
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #19734 (8977dd2) into develop (1c7c89a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #19734      +/-   ##
===========================================
+ Coverage    69.83%   69.83%   +0.01%     
===========================================
  Files          980      980              
  Lines        36886    36886              
  Branches      9890     9891       +1     
===========================================
+ Hits         25757    25759       +2     
+ Misses       11129    11127       -2     
Impacted Files Coverage Δ
shared/constants/snaps/permissions.ts 100.00% <ø> (ø)
ui/helpers/utils/permission.js 16.67% <ø> (ø)
...ib/rpc-method-middleware/createMethodMiddleware.js 57.35% <100.00%> (+2.94%) ⬆️

@metamaskbot
Copy link
Collaborator

Builds ready [8977dd2]
Page Load Metrics (1583 ± 67 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1012101382612
domContentLoaded14102042158314067
load14102042158314067
domInteractive14092042158314067
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 203617 bytes
  • ui: 0 bytes
  • common: 32941 bytes

@FrederikBolding FrederikBolding merged commit 3df690b into develop Jun 26, 2023
@FrederikBolding FrederikBolding deleted the fb/snaps@0.35.0 branch June 26, 2023 17:42
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
@metamaskbot metamaskbot added the release-10.34.0 Issue or pull request that will be included in release 10.34.0 label Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.0 Issue or pull request that will be included in release 10.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants