Deprecating FormField and fixing console error

[georgewrmarshall]

Explanation

Currently there are multiple component for form input fields. This PR deprecates the old FormField in favour of the new FormTextField component by adding a deprecation message that points to good-first-issue. It also replaces some deprecated components and constants in favor of enums as well as fixes a console error

• Fixes Deprecate old FormField in favour of appropriate FormTextField #18891
• Fixes Fix FormField console error #19736

• Slack thread

Screenshots/Screencaps

Before

before.mov

After

after.mov

Manual Testing Steps

• Checkout this branch
• Search FormField in the code base
• See strikethrough in VS code and deprecation message on hover

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [0923ce0]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1577 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	100	410	141	66	32
		domContentLoaded	1451	1790	1577	97	47
		load	1451	1790	1577	97	47
		domInteractive	1451	1790	1577	97	47

Bundle size diffs

• background: 0 bytes
• ui: -117 bytes
• common: 0 bytes

[codecov]

Codecov Report

Merging #19739 (0923ce0) into develop (fc2402d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19739      +/-   ##
===========================================
- Coverage    69.83%   69.83%   -0.00%     
===========================================
  Files          980      980              
  Lines        36886    36886              
  Branches      9890     9890              
===========================================
- Hits         25757    25756       -1     
- Misses       11129    11130       +1     

Impacted Files	Coverage Δ
ui/components/ui/form-field/form-field.js	94.59% <ø> (ø)

... and 1 file with indirect coverage changes