Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LavaMoat policies #19744

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Update LavaMoat policies #19744

merged 1 commit into from
Jun 23, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 23, 2023

Explanation

Update LavaMoat policies to match what CI expects.

Manual Testing Steps

CI should validate this

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

Update LavaMoat policies to match what CI expects.
@Gudahtt Gudahtt requested review from a team as code owners June 23, 2023 19:47
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gudahtt Gudahtt merged commit fc2402d into develop Jun 23, 2023
10 checks passed
@Gudahtt Gudahtt deleted the update-lavamoat-policies branch June 23, 2023 20:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
@metamaskbot metamaskbot added the release-10.34.0 Issue or pull request that will be included in release 10.34.0 label Jun 23, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [1785568]
Page Load Metrics (1552 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1042341433215
domContentLoaded1435174715528440
load1435174715528440
domInteractive1435174715528440
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 52 bytes
  • ui: 0 bytes
  • common: 0 bytes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.0 Issue or pull request that will be included in release 10.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants