Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @metamask/providers to v11.1.0 #19762

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jun 26, 2023

Explanation

  • Bump @metamask/providers to v11.1.0

This bring in experimental warning for wallet_watchAsset when used with ERC721 and ERC1155. Needed for 10.33.0 RC.

The breaking change from @metamask/providers v11 is making the minimum Node v16. We are on a minimum Node version of v16.20 for extension already.

Screenshots/Screencaps

Before

Screen.Recording.2023-06-26.at.10.34.19.AM.mov

After

Screen.Recording.2023-06-26.at.10.28.53.AM.mov

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@jiexi jiexi requested a review from a team as a code owner June 26, 2023 17:20
@jiexi jiexi requested a review from OGPoyraz June 26, 2023 17:20
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link

socket-security bot commented Jun 26, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #19762 (c9c8e62) into develop (3df690b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #19762   +/-   ##
========================================
  Coverage    69.85%   69.85%           
========================================
  Files          980      980           
  Lines        36911    36911           
  Branches      9909     9909           
========================================
  Hits         25782    25782           
  Misses       11129    11129           

@metamaskbot
Copy link
Collaborator

Builds ready [bad641b]
Page Load Metrics (1463 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1042501323316
domContentLoaded1388160714636833
load1389160714636833
domInteractive1388160714636833
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 merged commit 0c047ac into develop Jun 26, 2023
9 checks passed
@adonesky1 adonesky1 deleted the jl/bump-providers-11.1.0 branch June 26, 2023 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
@metamaskbot metamaskbot added the release-10.34.0 Issue or pull request that will be included in release 10.34.0 label Jun 26, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [c9c8e62]
Page Load Metrics (1574 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1031911302110
domContentLoaded13792094157416579
load13792094157416579
domInteractive13792094157416579
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.0 Issue or pull request that will be included in release 10.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants