-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @metamask/providers to v11.1.0 #19762
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Codecov Report
@@ Coverage Diff @@
## develop #19762 +/- ##
========================================
Coverage 69.85% 69.85%
========================================
Files 980 980
Lines 36911 36911
Branches 9909 9909
========================================
Hits 25782 25782
Misses 11129 11129 |
Builds ready [bad641b]
Page Load Metrics (1463 ± 33 ms)
Bundle size diffs
|
bad641b
to
9c8b5c5
Compare
9c8b5c5
to
fbb3dea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Builds ready [c9c8e62]
Page Load Metrics (1574 ± 79 ms)
Bundle size diffs
|
Explanation
This bring in experimental warning for
wallet_watchAsset
when used with ERC721 and ERC1155. Needed for 10.33.0 RC.The breaking change from @metamask/providers v11 is making the minimum Node v16. We are on a minimum Node version of v16.20 for extension already.
Screenshots/Screencaps
Before
Screen.Recording.2023-06-26.at.10.34.19.AM.mov
After
Screen.Recording.2023-06-26.at.10.28.53.AM.mov
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.