Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump @metamask/assets-controllers to ^13.0.0 #20916

Merged
merged 34 commits into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
b0304f3
Use assets controller preview
jiexi Sep 15, 2023
2e0d433
Updated asset-controllers preview build
jiexi Sep 15, 2023
366f0f3
Update asset controller usage in MMC
jiexi Sep 15, 2023
05ff65e
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 15, 2023
634de76
lint
jiexi Sep 15, 2023
5818256
lavamoat
jiexi Sep 15, 2023
70be99a
fix specs
jiexi Sep 15, 2023
cf25215
Use new preview build
jiexi Sep 21, 2023
482e362
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 21, 2023
2b09b23
Update addTokens usage
jiexi Sep 21, 2023
ff36b32
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 26, 2023
19cd4ae
Use new asset-controllers
jiexi Sep 26, 2023
5c3806b
Update tokenController usage
jiexi Sep 26, 2023
b67cfd4
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 26, 2023
e3e8cda
WIP
jiexi Sep 26, 2023
051a8d3
fix spec
jiexi Sep 26, 2023
a924d48
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 26, 2023
7c341ab
Update LavaMoat policies
metamaskbot Sep 26, 2023
b3a58ca
Fix watch-asset rpc spec
jiexi Sep 26, 2023
0d1f80c
Update AssetsController usages
jiexi Sep 26, 2023
6f5c35b
Merge remote-tracking branch 'origin/jl/mmp-1020/multichain-v1-tokens…
jiexi Sep 26, 2023
b57321f
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 26, 2023
2670074
Fix null image derefence
jiexi Sep 26, 2023
3ce6f5f
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 27, 2023
38512df
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 27, 2023
d070c30
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 27, 2023
eaf661f
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 27, 2023
6545944
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 28, 2023
1435dd9
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
legobeat Sep 29, 2023
5557313
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Sep 29, 2023
860e639
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Oct 2, 2023
4d86940
yarn dedupe
jiexi Oct 2, 2023
8a671ca
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Oct 3, 2023
d773e0c
Merge branch 'develop' into jl/mmp-1020/multichain-v1-tokens-controller
jiexi Oct 3, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/scripts/controllers/detect-tokens.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ describe('DetectTokensController', function () {

const tokenListMessenger = new ControllerMessenger().getRestricted({
name: 'TokenListController',
allowedEvents: ['TokenListController:stateChange'],
});
tokenListController = new TokenListController({
chainId: toHex(1),
Expand Down Expand Up @@ -251,6 +252,11 @@ describe('DetectTokensController', function () {
networkControllerMessenger,
'NetworkController:stateChange',
),
onTokenListStateChange: (listener) =>
tokenListMessenger.subscribe(
`${tokenListController.name}:stateChange`,
listener,
),
});

assetsContractController = new AssetsContractController({
Expand Down Expand Up @@ -365,6 +371,7 @@ describe('DetectTokensController', function () {
aggregators: undefined,
image: undefined,
isERC721: undefined,
name: undefined,
},
]);

Expand All @@ -386,6 +393,7 @@ describe('DetectTokensController', function () {
aggregators: undefined,
image: undefined,
isERC721: undefined,
name: undefined,
},
]);
});
Expand Down Expand Up @@ -419,6 +427,7 @@ describe('DetectTokensController', function () {
aggregators: undefined,
image: undefined,
isERC721: undefined,
name: undefined,
},
]);
const tokenAddressToAdd = erc20ContractAddresses[1];
Expand All @@ -437,6 +446,7 @@ describe('DetectTokensController', function () {
aggregators: undefined,
image: undefined,
isERC721: undefined,
name: undefined,
},
{
address: toChecksumHexAddress(tokenAddressToAdd),
Expand All @@ -445,6 +455,7 @@ describe('DetectTokensController', function () {
aggregators: undefined,
image: undefined,
isERC721: undefined,
name: undefined,
},
]);
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ async function watchAssetHandler(
const {
params: { options: asset, type },
origin,
networkClientId,
} = req;

const { tokenId } = asset;
Expand All @@ -56,7 +57,7 @@ async function watchAssetHandler(
);
}

await handleWatchAssetRequest(asset, type, origin);
await handleWatchAssetRequest({ asset, type, origin, networkClientId });
res.result = true;
return end();
} catch (error) {
Expand Down
4 changes: 2 additions & 2 deletions app/scripts/metamask-controller.actions.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -244,8 +244,8 @@ describe('MetaMaskController', function () {
);

const [token1, token2] = await Promise.all([
metamaskController.getApi().addToken(address, symbol, decimals),
metamaskController.getApi().addToken(address, symbol, decimals),
metamaskController.getApi().addToken({ address, symbol, decimals }),
metamaskController.getApi().addToken({ address, symbol, decimals }),
]);
assert.deepEqual(token1, token2);
});
Expand Down
20 changes: 18 additions & 2 deletions app/scripts/metamask-controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,14 @@ export default class MetamaskController extends EventEmitter {
networkControllerMessenger,
'NetworkController:stateChange',
),
onTokenListStateChange: (listener) =>
this.controllerMessenger.subscribe(
`${this.tokenListController.name}:stateChange`,
listener,
),
getNetworkClientById: this.networkController.getNetworkClientById.bind(
this.networkController,
),
config: { provider: this.provider },
state: initState.TokensController,
});
Expand Down Expand Up @@ -741,6 +749,10 @@ export default class MetamaskController extends EventEmitter {
networkControllerMessenger,
'NetworkController:stateChange',
),
onPreferencesStateChange:
this.preferencesController.store.subscribe.bind(
this.preferencesController.store,
),
},
{
disabled:
Expand Down Expand Up @@ -3813,10 +3825,14 @@ export default class MetamaskController extends EventEmitter {
});
}

handleWatchAssetRequest = (asset, type, origin) => {
handleWatchAssetRequest = ({ asset, type, origin, networkClientId }) => {
switch (type) {
case ERC20:
return this.tokensController.watchAsset(asset, type);
return this.tokensController.watchAsset({
asset,
type,
networkClientId,
});
case ERC721:
case ERC1155:
return this.nftController.watchNft(asset, type, origin);
Expand Down
18 changes: 16 additions & 2 deletions lavamoat/browserify/beta/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -773,15 +773,15 @@
"@ethersproject/providers": true,
"@metamask/assets-controllers>@metamask/abi-utils": true,
"@metamask/assets-controllers>@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/utils": true,
"@metamask/assets-controllers>abort-controller": true,
"@metamask/assets-controllers>multiformats": true,
"@metamask/base-controller": true,
"@metamask/contract-metadata": true,
"@metamask/controller-utils": true,
"@metamask/controller-utils>@metamask/eth-query": true,
"@metamask/metamask-eth-abis": true,
"@metamask/utils": true,
"eth-json-rpc-filters>async-mutex": true,
"eth-query": true,
"ethereumjs-util": true,
"single-call-balance-checker-abi": true,
"uuid": true,
Expand All @@ -800,6 +800,7 @@
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
Expand All @@ -812,6 +813,19 @@
"eth-rpc-errors>fast-safe-stringify": true
}
},
"@metamask/assets-controllers>@metamask/utils": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
"superstruct": true
}
},
"@metamask/assets-controllers>abort-controller": {
"globals": {
"AbortController": true
Expand Down
18 changes: 16 additions & 2 deletions lavamoat/browserify/desktop/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -773,15 +773,15 @@
"@ethersproject/providers": true,
"@metamask/assets-controllers>@metamask/abi-utils": true,
"@metamask/assets-controllers>@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/utils": true,
"@metamask/assets-controllers>abort-controller": true,
"@metamask/assets-controllers>multiformats": true,
"@metamask/base-controller": true,
"@metamask/contract-metadata": true,
"@metamask/controller-utils": true,
"@metamask/controller-utils>@metamask/eth-query": true,
"@metamask/metamask-eth-abis": true,
"@metamask/utils": true,
"eth-json-rpc-filters>async-mutex": true,
"eth-query": true,
"ethereumjs-util": true,
"single-call-balance-checker-abi": true,
"uuid": true,
Expand All @@ -800,6 +800,7 @@
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
Expand All @@ -812,6 +813,19 @@
"eth-rpc-errors>fast-safe-stringify": true
}
},
"@metamask/assets-controllers>@metamask/utils": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
"superstruct": true
}
},
"@metamask/assets-controllers>abort-controller": {
"globals": {
"AbortController": true
Expand Down
18 changes: 16 additions & 2 deletions lavamoat/browserify/flask/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -773,15 +773,15 @@
"@ethersproject/providers": true,
"@metamask/assets-controllers>@metamask/abi-utils": true,
"@metamask/assets-controllers>@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/utils": true,
"@metamask/assets-controllers>abort-controller": true,
"@metamask/assets-controllers>multiformats": true,
"@metamask/base-controller": true,
"@metamask/contract-metadata": true,
"@metamask/controller-utils": true,
"@metamask/controller-utils>@metamask/eth-query": true,
"@metamask/metamask-eth-abis": true,
"@metamask/utils": true,
"eth-json-rpc-filters>async-mutex": true,
"eth-query": true,
"ethereumjs-util": true,
"single-call-balance-checker-abi": true,
"uuid": true,
Expand All @@ -800,6 +800,7 @@
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
Expand All @@ -812,6 +813,19 @@
"eth-rpc-errors>fast-safe-stringify": true
}
},
"@metamask/assets-controllers>@metamask/utils": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
"superstruct": true
}
},
"@metamask/assets-controllers>abort-controller": {
"globals": {
"AbortController": true
Expand Down
18 changes: 16 additions & 2 deletions lavamoat/browserify/main/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -773,15 +773,15 @@
"@ethersproject/providers": true,
"@metamask/assets-controllers>@metamask/abi-utils": true,
"@metamask/assets-controllers>@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/utils": true,
"@metamask/assets-controllers>abort-controller": true,
"@metamask/assets-controllers>multiformats": true,
"@metamask/base-controller": true,
"@metamask/contract-metadata": true,
"@metamask/controller-utils": true,
"@metamask/controller-utils>@metamask/eth-query": true,
"@metamask/metamask-eth-abis": true,
"@metamask/utils": true,
"eth-json-rpc-filters>async-mutex": true,
"eth-query": true,
"ethereumjs-util": true,
"single-call-balance-checker-abi": true,
"uuid": true,
Expand All @@ -800,6 +800,7 @@
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
Expand All @@ -812,6 +813,19 @@
"eth-rpc-errors>fast-safe-stringify": true
}
},
"@metamask/assets-controllers>@metamask/utils": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
"superstruct": true
}
},
"@metamask/assets-controllers>abort-controller": {
"globals": {
"AbortController": true
Expand Down
18 changes: 16 additions & 2 deletions lavamoat/browserify/mmi/policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -913,15 +913,15 @@
"@ethersproject/providers": true,
"@metamask/assets-controllers>@metamask/abi-utils": true,
"@metamask/assets-controllers>@metamask/rpc-errors": true,
"@metamask/assets-controllers>@metamask/utils": true,
"@metamask/assets-controllers>abort-controller": true,
"@metamask/assets-controllers>multiformats": true,
"@metamask/base-controller": true,
"@metamask/contract-metadata": true,
"@metamask/controller-utils": true,
"@metamask/controller-utils>@metamask/eth-query": true,
"@metamask/metamask-eth-abis": true,
"@metamask/utils": true,
"eth-json-rpc-filters>async-mutex": true,
"eth-query": true,
"ethereumjs-util": true,
"single-call-balance-checker-abi": true,
"uuid": true,
Expand All @@ -940,6 +940,7 @@
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
Expand All @@ -952,6 +953,19 @@
"eth-rpc-errors>fast-safe-stringify": true
}
},
"@metamask/assets-controllers>@metamask/utils": {
"globals": {
"TextDecoder": true,
"TextEncoder": true
},
"packages": {
"@metamask/key-tree>@noble/hashes": true,
"browserify>buffer": true,
"nock>debug": true,
"semver": true,
"superstruct": true
}
},
"@metamask/assets-controllers>abort-controller": {
"globals": {
"AbortController": true
Expand Down
Loading
Loading