Add privacy setting to disable external name sources #21045

matthewwalsh0 · 2023-09-26T12:48:19Z

Description

Add a toggle to the Security & privacy settings in the Flask build to disable the use of any NameProvider which uses an external source.

This disables the EtherscanNameProvider, LensNameProvider, and TokenNameProvider from making any callouts and therefore prevents any proposed names being displayed in the NameDetails component, except for any values provided by installed snaps.

Manual Testing Steps

Go to test dApp.
Connect.
Switch to mainnet.
Copy this URL and replace %CURRENT_ACCOUNT_ADDRESS% with your current account address.
This will load a V4 signature request in the test dapp including addresses which will should all have proposed names.
Select the last address and verify there is a Lens Protocol and ENS proposed name.
Go to Settings > Security & privacy > Suggest address names and disable it.
Wait 2 minutes.
Go back to the above URL and select the last address.
Ensure only the ENS proposed name is shown.

Screenshots

Pre-merge Author Checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Create associated unit tests.

Update proposed names from name details component. Truncate in name component. Truncate in name details component. Sort proposed names by source label.

github-actions · 2023-09-26T12:48:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Normalize values in hook.

…toggle

Move name detail metric logic into separate file.

…toggle

codecov · 2023-09-29T19:41:51Z

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (b7ad9f6) 68.49% compared to head (bad1b19) 68.47%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #21045      +/-   ##
===========================================
- Coverage    68.49%   68.47%   -0.02%     
===========================================
  Files         1012     1012              
  Lines        40588    40610      +22     
  Branches     10843    10839       -4     
===========================================
+ Hits         27799    27807       +8     
- Misses       12789    12803      +14

Files	Coverage Δ
app/scripts/controllers/preferences.js	`57.05% <80.00%> (+0.09%)`	⬆️
...es/settings/security-tab/security-tab.component.js	`99.24% <80.00%> (-0.76%)`	⬇️
app/scripts/metamask-controller.js	`53.74% <75.00%> (-0.11%)`	⬇️
...es/settings/security-tab/security-tab.container.js	`86.36% <0.00%> (-8.64%)`	⬇️
ui/store/actions.ts	`43.24% <0.00%> (-0.10%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-09-29T19:51:25Z

Builds ready [a585e1e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1144 ± 332 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	81	126	97	11	5
		domContentLoaded	72	118	91	11	5
		load	77	1791	1144	692	332
		domInteractive	72	118	91	11	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 719 Bytes (0.02%)
ui: -16.16 KiB (-0.20%)
common: 55.22 KiB (1.18%)

…toggle

metamaskbot · 2023-09-30T14:26:24Z

Builds ready [d70efc7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1084 ± 348 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	128	99	13	6
		domContentLoaded	72	120	94	12	6
		load	80	1755	1084	725	348
		domInteractive	72	120	94	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 719 Bytes (0.02%)
ui: -16.16 KiB (-0.20%)
common: 55.22 KiB (1.18%)

Ameralameri

Approv

sleepytanya · 2023-10-01T16:59:47Z

Toggle Settings > Security & privacy > Suggest address names works as designed.

Suggested addresses with Suggest address names toggle on:

Last address with Lens Protocol and ENS proposed name:

Proposed names not displayed in the NameDetails component after disabling Suggest address names:

For the last address only ENS proposed name is shown:

The base branch was changed.

metamaskbot · 2023-10-02T12:40:32Z

Builds ready [bad1b19]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (928 ± 393 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	159	118	14	7
		domContentLoaded	76	146	109	18	9
		load	87	1972	928	819	393
		domInteractive	76	146	108	18	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 372 Bytes (0.01%)

matthewwalsh0 added 10 commits September 20, 2023 20:17

Add petnames metrics

f41e25f

Update metrics

d8d2bd3

Create associated unit tests.

Add user trait

75b3827

Fix linting

be83db9

Merge branch 'develop' into feat/petnames-metrics

1c4d20f

Merge branch 'develop' into feat/petnames-metrics

97761f7

Remove proposed name from name component

3b8d34b

Update proposed names from name details component. Truncate in name component. Truncate in name details component. Sort proposed names by source label.

Fix name clearing

cece879

Update name controller

c834ed3

Add settings toggle to disable external name providers

a89cda4

matthewwalsh0 requested a review from a team as a code owner September 26, 2023 12:48

matthewwalsh0 added 18 commits September 26, 2023 15:57

Update name controller

edd5403

Update name controller

233be51

Update yarn lock

eed4d40

Merge branch 'develop' into feat/petnames-metrics

897d278

Display checksum addresses

4db917e

Normalize values in hook.

Update name controller

f1e5778

Add unit tests

18566b8

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

5e701d0

…toggle

Fix linting

3b332f6

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

37d52f1

…toggle

Fix unit tests

7062cc8

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

e0e324f

…toggle

Update text

881e17a

Update name controller

0609838

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

7f2a158

…toggle

Merge branch 'develop' into feat/petnames-metrics

eeb00a2

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

52e3c71

…toggle

Send open metric after proposed names are loaded

0504df9

Move name detail metric logic into separate file.

matthewwalsh0 added 8 commits September 29, 2023 18:04

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

24cbc7d

…toggle

Update policies

8d1c873

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

b2e05a9

…toggle

Fix E2E test

633a467

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

59013c3

…toggle

Update snapshot

b11e751

Fix unit test

5f67213

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

a585e1e

…toggle

matthewwalsh0 added 3 commits September 29, 2023 22:25

Refactor E2E tests

35cd3ac

Merge branch 'develop' into feat/petnames-metrics

b596e4e

Merge branch 'feat/petnames-metrics' into feat/external-name-sources-…

d70efc7

…toggle

Ameralameri approved these changes Sep 30, 2023

View reviewed changes

OGPoyraz previously approved these changes Oct 2, 2023

View reviewed changes

Base automatically changed from feat/petnames-metrics to develop October 2, 2023 09:21

matthewwalsh0 requested review from a team as code owners October 2, 2023 09:21

Merge branch 'develop' into feat/external-name-sources-toggle

bad1b19

matthewwalsh0 added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Oct 2, 2023

vinistevam approved these changes Oct 3, 2023

View reviewed changes

cryptotavares approved these changes Oct 3, 2023

View reviewed changes

matthewwalsh0 merged commit ab0fdee into develop Oct 3, 2023
64 of 65 checks passed

matthewwalsh0 deleted the feat/external-name-sources-toggle branch October 3, 2023 09:58

github-actions bot locked and limited conversation to collaborators Oct 3, 2023

metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Oct 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add privacy setting to disable external name sources #21045

Add privacy setting to disable external name sources #21045

matthewwalsh0 commented Sep 26, 2023 •

edited

Loading

github-actions bot commented Sep 26, 2023

codecov bot commented Sep 29, 2023 •

edited

Loading

metamaskbot commented Sep 29, 2023

metamaskbot commented Sep 30, 2023

Ameralameri left a comment

sleepytanya commented Oct 1, 2023 •

edited

Loading

metamaskbot commented Oct 2, 2023

Add privacy setting to disable external name sources #21045

Add privacy setting to disable external name sources #21045

Conversation

matthewwalsh0 commented Sep 26, 2023 • edited Loading

Description

Manual Testing Steps

Screenshots

Pre-merge Author Checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 26, 2023

codecov bot commented Sep 29, 2023 • edited Loading

Codecov Report

metamaskbot commented Sep 29, 2023

metamaskbot commented Sep 30, 2023

Ameralameri left a comment

Choose a reason for hiding this comment

sleepytanya commented Oct 1, 2023 • edited Loading

metamaskbot commented Oct 2, 2023

matthewwalsh0 commented Sep 26, 2023 •

edited

Loading

codecov bot commented Sep 29, 2023 •

edited

Loading

sleepytanya commented Oct 1, 2023 •

edited

Loading