-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add privacy setting to disable external name sources #21045
Conversation
Create associated unit tests.
Update proposed names from name details component. Truncate in name component. Truncate in name details component. Sort proposed names by source label.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Normalize values in hook.
Move name detail metric logic into separate file.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #21045 +/- ##
===========================================
- Coverage 68.49% 68.47% -0.02%
===========================================
Files 1012 1012
Lines 40588 40610 +22
Branches 10843 10839 -4
===========================================
+ Hits 27799 27807 +8
- Misses 12789 12803 +14
☔ View full report in Codecov by Sentry. |
Builds ready [a585e1e]
Page Load Metrics (1144 ± 332 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [d70efc7]
Page Load Metrics (1084 ± 348 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approv
Builds ready [bad1b19]
Page Load Metrics (928 ± 393 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Add a toggle to the
Security & privacy
settings in theFlask
build to disable the use of anyNameProvider
which uses an external source.This disables the
EtherscanNameProvider
,LensNameProvider
, andTokenNameProvider
from making any callouts and therefore prevents any proposed names being displayed in theNameDetails
component, except for any values provided by installed snaps.Manual Testing Steps
%CURRENT_ACCOUNT_ADDRESS%
with your current account address.Lens Protocol
andENS
proposed name.Settings
>Security & privacy
>Suggest address names
and disable it.Screenshots
Pre-merge Author Checklist
Pre-merge reviewer checklist