Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] - Updates the mmi packages, containing a small fix #21164

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Oct 3, 2023

Updates the MMI packages, specifically the SDK one that contains a fix regarding the content-type header of a client api being set wrongly.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@zone-live zone-live added team-mmi PRs from the MMI team release-11.2.0 Issue or pull request that will be included in release 11.2.0 labels Oct 3, 2023
@zone-live zone-live requested a review from a team as a code owner October 3, 2023 10:57
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live requested a review from shane-t October 3, 2023 10:57
@zone-live
Copy link
Contributor Author

@metamaskbot update-policies

@zone-live zone-live changed the title [MMI] - Updates the mmi packages [MMI] - Updates the mmi packages, containing a small fix Oct 3, 2023
shane-t
shane-t previously approved these changes Oct 3, 2023
@metamaskbot
Copy link
Collaborator

No policy changes

@metamaskbot
Copy link
Collaborator

Builds ready [08a3ed0]
Page Load Metrics (1183 ± 377 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint93164118189
domContentLoaded751571112110
load9219361183784377
domInteractive751571112110
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 20 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (0107c2c) 68.49% compared to head (08a3ed0) 68.57%.
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #21164      +/-   ##
===========================================
+ Coverage    68.49%   68.57%   +0.08%     
===========================================
  Files         1012     1013       +1     
  Lines        40588    40615      +27     
  Branches     10843    10854      +11     
===========================================
+ Hits         27799    27848      +49     
+ Misses       12789    12767      -22     
Files Coverage Δ
app/scripts/controllers/mmi-controller.js 15.00% <100.00%> (-2.39%) ⬇️
...cripts/lib/rpc-method-middleware/handlers/index.js 100.00% <ø> (ø)
...ummary/confirm-page-container-summary.component.js 87.80% <100.00%> (+3.59%) ⬆️
...nents/app/transaction-alerts/transaction-alerts.js 100.00% <100.00%> (ø)
.../components/app/whats-new-popup/whats-new-popup.js 40.91% <100.00%> (-1.16%) ⬇️
...n/account-list-item-menu/account-list-item-menu.js 80.00% <ø> (+14.55%) ⬆️
...-conversion-button/asset-list-conversion-button.js 100.00% <100.00%> (ø)
...transaction-base/confirm-token-transaction-base.js 1.69% <ø> (ø)
...saction-base/confirm-transaction-base.component.js 56.60% <ø> (ø)
ui/pages/home/home.component.js 46.83% <100.00%> (+0.23%) ⬆️
... and 9 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live merged commit 0482ab6 into develop Oct 3, 2023
64 checks passed
@zone-live zone-live deleted the MMI-3929-update-mmi-packages-due-to-hostfix branch October 3, 2023 13:26
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Oct 3, 2023
@gauthierpetetin gauthierpetetin added release-11.1.2 Issue or pull request that will be included in release 11.1.2 and removed release-11.3.0 Issue or pull request that will be included in release 11.3.0 release-11.2.0 Issue or pull request that will be included in release 11.2.0 labels Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.2 Issue or pull request that will be included in release 11.1.2 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants