Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix update nft metadata #23558

Closed
wants to merge 1 commit into from

Conversation

sahar-fehri
Copy link
Contributor

Description

Fetches NFT metadata when IPFS toggle or Display media toggle are on

Open in GitHub Codespaces

Related issues

Core PR: MetaMask/core#4008

Manual testing steps

  1. Go to settings and disable IPFS toggle and disable display Media toggle
  2. Import an NFT (where metadata is hosted on IPFS)
  3. Enable IPFS toggle
  4. You should see the image on the home page
  5. Import an NFT where NFT metadata are hosted on https server
  6. Go to settings and enable the display media toggle
  7. You should see the NFT metadata on home page

Screenshots/Recordings

Before

Screen.Recording.2024-03-04.at.14.31.31.mov

After

videoAfter.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner March 18, 2024 17:33
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri
Copy link
Contributor Author

Closing in favor of this fix MetaMask/core#4096

@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants