feat: use Infura gas API #23717

OGPoyraz · 2024-03-26T07:48:14Z

Description

This PR introduces an updated GasFeeController that transitions to the new Infura gas API.

Preview GasFeeController PR: MetaMask/core#4068

Important Note: With the introduction of these changes, developers must complete two critical steps within their Infura project:

Activate the Infura gas API in the Expansion APIs section.

Access this section via https://app.infura.io/key/<INFURA_PROJECT_ID>/all-endpoints. Please replace <INFURA_PROJECT_ID> with the project ID found in your .metamaskrc file.

Ensure that the REQUIRE API KEY SECRET FOR ALL REQUESTS option is disabled.

Access this section via https://app.infura.io/key/<INFURA_PROJECT_ID>/settings. Again, <INFURA_PROJECT_ID> with the project ID found in your .metamaskrc file.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2254

Manual testing steps

Although there are no functional changes, the update to the gas API URL warrants manual testing of gas-related components to ensure they remain operational.

Screenshots/Recordings

N/A

Before

N/A

After

N/A

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

OGPoyraz · 2024-03-26T07:48:53Z

@metamaskbot update-policies

metamaskbot · 2024-03-26T07:56:41Z

Policies updated

OGPoyraz · 2024-03-28T08:42:17Z

@metamaskbot update-policies

metamaskbot · 2024-03-28T08:43:24Z

Policy update failed. You can review the logs or retry the policy update here

OGPoyraz · 2024-03-28T08:44:03Z

@metamaskbot update-policies

metamaskbot · 2024-03-28T08:53:34Z

Policies updated

OGPoyraz · 2024-03-28T16:57:09Z

test/e2e/mock-e2e.js

@@ -190,6 +190,54 @@ async function setupMocking(server, testSpecificMock, { chainId }) {
      };
    });

+  // Both are added to support swaps e2e tests


Gas prices are fetch within swaps UI

I am not sure why chainId is override in the tests

Basically if we don't put these mocks then swaps e2e tests will fail, because it's not being caught by XHR mocks and auth modal will appear (as expected in the screenshot)

This is a quick fix but just patching the current implementation, fyi

To clarify, are you saying you believe this wasn't being mocked previously and was hitting the real endpoint?

Indeed, this issue went unnoticed previously because the former endpoint shared the same domain, allowing it to bypass the privacy snapshot. However, the new endpoint is protected by authentication, which explains why it is prompting for credentials, as in the screenshot.

metamaskbot · 2024-03-28T17:02:12Z

Builds ready [2949a1b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (980 ± 533 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	75	347	138	75	36
		domContentLoaded	11	67	24	14	7
		load	62	3337	980	1110	533
		domInteractive	11	67	24	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -111 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 355 Bytes (0.01%)

codecov · 2024-03-28T17:02:24Z

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.17%. Comparing base (860c03f) to head (2949a1b).
Report is 121 commits behind head on develop.

❗ Current head 2949a1b differs from pull request most recent head a5df691. Consider uploading reports for the commit a5df691 to get more accurate results

Files	Patch %	Lines
app/scripts/metamask-controller.js	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #23717      +/-   ##
===========================================
+ Coverage    69.11%   69.17%   +0.05%     
===========================================
  Files         1160     1160              
  Lines        44296    44263      -33     
  Branches     11850    11832      -18     
===========================================
  Hits         30615    30615              
+ Misses       13681    13648      -33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shared/constants/swaps.ts

matthewwalsh0 · 2024-03-28T20:32:31Z

test/e2e/mock-e2e.js

@@ -190,6 +190,54 @@ async function setupMocking(server, testSpecificMock, { chainId }) {
      };
    });

+  // Both are added to support swaps e2e tests


To clarify, are you saying you believe this wasn't being mocked previously and was hitting the real endpoint?

test/e2e/mock-e2e.js

metamaskbot · 2024-04-15T10:03:45Z

Builds ready [afbf079]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1451 ± 599 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	361	153	73	35
		domContentLoaded	10	90	29	19	9
		load	68	3209	1451	1248	599
		domInteractive	10	90	29	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -111 Bytes (-0.00%)
ui: 333 Bytes (0.00%)
common: 355 Bytes (0.01%)

OGPoyraz · 2024-04-18T13:57:35Z

@metamaskbot update-policies

metamaskbot · 2024-04-18T14:07:48Z

Policies updated

metamaskbot · 2024-04-22T08:39:42Z

Builds ready [83216da]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1221 ± 604 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	355	120	59	29
		domContentLoaded	12	53	23	9	4
		load	55	2875	1221	1258	604
		domInteractive	12	53	23	9	4

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 115.55 KiB (3.33%)
ui: 0 Bytes (0.00%)
common: 1.01 KiB (0.02%)

sleepytanya · 2024-04-22T17:36:15Z

The PR looks great to me. All basic gas fee flows as well as different gas settings work as expected.

metamaskbot · 2024-04-23T09:04:12Z

Builds ready [4281423]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1799 ± 684 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	203	137	38	18
		domContentLoaded	10	78	30	18	8
		load	65	3509	1799	1424	684
		domInteractive	10	78	30	18	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 115.55 KiB (3.30%)
ui: 0 Bytes (0.00%)
common: 1.01 KiB (0.02%)

Consume latest gas api

d82803a

OGPoyraz added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Mar 26, 2024

Update latest packages

6be0acb

OGPoyraz force-pushed the feat/use-infura-gas-api branch from 5997d1e to 6be0acb Compare March 28, 2024 08:40

Merge branch 'develop' into feat/use-infura-gas-api

130a4c9

OGPoyraz marked this pull request as ready for review March 28, 2024 08:42

OGPoyraz requested a review from a team as a code owner March 28, 2024 08:42

update yarn lock

63a0fbf

Update LavaMoat policies

d041cb6

OGPoyraz requested review from a team as code owners March 28, 2024 08:53

OGPoyraz added 2 commits March 28, 2024 10:10

Merge branch 'develop' into feat/use-infura-gas-api

63ac478

Update privacy snapshot

0eb4339

OGPoyraz requested a review from a team as a code owner March 28, 2024 09:46

OGPoyraz added 6 commits March 28, 2024 10:51

Remove old gas api url from privacy snapshot file

02f957b

Fix e2e tests

8317208

Merge branch 'develop' into feat/use-infura-gas-api

295b560

Merge branch 'develop' into feat/use-infura-gas-api

f18a886

Merge branch 'develop' into feat/use-infura-gas-api

047e4fc

Fix swaps e2e tests

2949a1b

OGPoyraz commented Mar 28, 2024

View reviewed changes

matthewwalsh0 reviewed Mar 28, 2024

View reviewed changes

OGPoyraz added 2 commits April 15, 2024 11:25

Update tests

a5df691

Add auth header for gasPrices

afbf079

matthewwalsh0 previously approved these changes Apr 18, 2024

View reviewed changes

OGPoyraz added 2 commits April 18, 2024 14:38

Merge branch 'develop' into feat/use-infura-gas-api

88c2533

Merge branch 'develop' into feat/use-infura-gas-api

dcd66ee

Update LavaMoat policies

770076b

metamaskbot dismissed matthewwalsh0’s stale review via 770076b April 18, 2024 14:07

sleepytanya mentioned this pull request Apr 18, 2024

[Bug]: Transactions might be marked as 'Failed' while they are successfully confirmed according to the block explorer #23660

Closed

Merge branch 'develop' into feat/use-infura-gas-api

83216da

matthewwalsh0 approved these changes Apr 22, 2024

View reviewed changes

sleepytanya added the QA Passed label Apr 22, 2024

vinistevam approved these changes Apr 23, 2024

View reviewed changes

Merge branch 'develop' into feat/use-infura-gas-api

4281423

danjm approved these changes Apr 23, 2024

View reviewed changes

OGPoyraz merged commit 3ed1ee1 into develop Apr 23, 2024
66 of 69 checks passed

OGPoyraz deleted the feat/use-infura-gas-api branch April 23, 2024 08:56

github-actions bot locked and limited conversation to collaborators Apr 23, 2024

metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use Infura gas API #23717

feat: use Infura gas API #23717

OGPoyraz commented Mar 26, 2024 •

edited

Loading

OGPoyraz commented Mar 26, 2024

metamaskbot commented Mar 26, 2024

OGPoyraz commented Mar 28, 2024

metamaskbot commented Mar 28, 2024

OGPoyraz commented Mar 28, 2024

metamaskbot commented Mar 28, 2024

OGPoyraz Mar 28, 2024 •

edited

Loading

matthewwalsh0 Mar 28, 2024

OGPoyraz Apr 15, 2024

metamaskbot commented Mar 28, 2024

codecov bot commented Mar 28, 2024 •

edited

Loading

matthewwalsh0 Mar 28, 2024

metamaskbot commented Apr 15, 2024

OGPoyraz commented Apr 18, 2024

metamaskbot commented Apr 18, 2024

metamaskbot commented Apr 22, 2024

sleepytanya commented Apr 22, 2024

metamaskbot commented Apr 23, 2024

feat: use Infura gas API #23717

feat: use Infura gas API #23717

Conversation

OGPoyraz commented Mar 26, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

OGPoyraz commented Mar 26, 2024

metamaskbot commented Mar 26, 2024

OGPoyraz commented Mar 28, 2024

metamaskbot commented Mar 28, 2024

OGPoyraz commented Mar 28, 2024

metamaskbot commented Mar 28, 2024

OGPoyraz Mar 28, 2024 • edited Loading

Choose a reason for hiding this comment

matthewwalsh0 Mar 28, 2024

Choose a reason for hiding this comment

OGPoyraz Apr 15, 2024

Choose a reason for hiding this comment

metamaskbot commented Mar 28, 2024

codecov bot commented Mar 28, 2024 • edited Loading

Codecov Report

matthewwalsh0 Mar 28, 2024

Choose a reason for hiding this comment

metamaskbot commented Apr 15, 2024

OGPoyraz commented Apr 18, 2024

metamaskbot commented Apr 18, 2024

metamaskbot commented Apr 22, 2024

sleepytanya commented Apr 22, 2024

metamaskbot commented Apr 23, 2024

OGPoyraz commented Mar 26, 2024 •

edited

Loading

OGPoyraz Mar 28, 2024 •

edited

Loading

codecov bot commented Mar 28, 2024 •

edited

Loading