Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add patch for fetching tokenURI for ERC404 #24029

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Apr 15, 2024

Description

We have been contacted about an NFT on linea mainnet that was not showing properly on MM.
There is this core PR that has been merged to fix fetch behavior for ERC404: MetaMask/core#4136

This PR adds a patch for the core fix.

Open in GitHub Codespaces

Related issues

Fixes:
Related: MetaMask/core#4136

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

Screen.Recording.2024-04-15.at.14.43.34.mov

After

Screen.Recording.2024-04-15.at.14.37.08.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri requested a review from a team as a code owner April 15, 2024 12:48
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Apr 15, 2024
@salimtb
Copy link
Contributor

salimtb commented Apr 16, 2024

@sahar-fehri be careful, your patch will edit the yarn.lock , this should be included on the change files list and submitted for a review

@metamaskbot
Copy link
Collaborator

Builds ready [154a7cb]
Page Load Metrics (1226 ± 556 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6936917510148
domContentLoaded96428189
load53279012261159556
domInteractive96428189
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -6 Bytes (-0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [885be71]
Page Load Metrics (2053 ± 712 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint823891778742
domContentLoaded13131362914
load68417920531483712
domInteractive13131362914
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -6 Bytes (-0.00%)

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.60%. Comparing base (af2647e) to head (885be71).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #24029   +/-   ##
========================================
  Coverage    67.60%   67.60%           
========================================
  Files         1251     1251           
  Lines        49000    49000           
  Branches     12793    12793           
========================================
  Hits         33125    33125           
  Misses       15875    15875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sahar-fehri sahar-fehri merged commit af50f46 into develop Apr 19, 2024
68 of 69 checks passed
@sahar-fehri sahar-fehri deleted the fix/patch-linea-mainnet-ERC404-fix branch April 19, 2024 12:03
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants