-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add patch for fetching tokenURI for ERC404 #24029
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@sahar-fehri be careful, your patch will edit the yarn.lock , this should be included on the change files list and submitted for a review |
Builds ready [154a7cb]
Page Load Metrics (1226 ± 556 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Builds ready [885be71]
Page Load Metrics (2053 ± 712 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24029 +/- ##
========================================
Coverage 67.60% 67.60%
========================================
Files 1251 1251
Lines 49000 49000
Branches 12793 12793
========================================
Hits 33125 33125
Misses 15875 15875 ☔ View full report in Codecov by Sentry. |
Description
We have been contacted about an NFT on linea mainnet that was not showing properly on MM.
There is this core PR that has been merged to fix fetch behavior for ERC404: MetaMask/core#4136
This PR adds a patch for the core fix.
Related issues
Fixes:
Related: MetaMask/core#4136
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-04-15.at.14.43.34.mov
After
Screen.Recording.2024-04-15.at.14.37.08.mov
Pre-merge author checklist
Pre-merge reviewer checklist