Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adds quality gate for rerunning e2e spec files that are new or have been modified #24556

Merged
merged 54 commits into from
Jul 1, 2024
Merged

chore: adds quality gate for rerunning e2e spec files that are new or have been modified #24556

merged 54 commits into from
Jul 1, 2024
+244 −18

Commits on May 16, 2024

  1. quality gate mock alt

    @seaona
    seaona committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e66f2fa View commit details
    Browse the repository at this point in the history

  2. fix export

    @seaona
    seaona committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d2298f6 View commit details
    Browse the repository at this point in the history

  3. fix PR number match

    @seaona
    seaona committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d89be42 View commit details
    Browse the repository at this point in the history

  4. overwrite retries number for retry-until-failure cases

    @seaona
    seaona committed May 16, 2024
    Configuration menu
    Copy the full SHA
    57269c9 View commit details
    Browse the repository at this point in the history

  5. change file to ts and add log for debugging

    @seaona
    seaona committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3a8b0fa View commit details
    Browse the repository at this point in the history

  6. revert js

    @seaona
    seaona committed May 16, 2024
    Configuration menu
    Copy the full SHA
    90690cd View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. add ts spec files to the filter and make another test fail to verify … 

    …logic is working properly in failing tests
    @seaona
    seaona committed May 20, 2024
    Configuration menu
    Copy the full SHA
    65b3467 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. address dev review: move retries to variable remove try/catch

    @seaona
    seaona committed May 21, 2024
    Configuration menu
    Copy the full SHA
    df8d21e View commit details
    Browse the repository at this point in the history

  2. leave the specs as they were before (changed for ci testing purposes)

    @seaona
    seaona committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5029d49 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into quality-gate-gh

    @seaona
    seaona authored May 21, 2024
    Configuration menu
    Copy the full SHA
    71bbf50 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Quality gate gh ci job (#24787) 

    <!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24787?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
    @seaona
    seaona authored May 27, 2024
    Configuration menu
    Copy the full SHA
    1c728ac View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. address comments

    @seaona
    seaona committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c46b3b8 View commit details
    Browse the repository at this point in the history

  2. origin develop

    @seaona
    seaona committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b6d1f45 View commit details
    Browse the repository at this point in the history

  3. depth update

    @seaona
    seaona committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    870f875 View commit details
    Browse the repository at this point in the history

  4. 50 fetch

    @seaona
    seaona committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    81f954a View commit details
    Browse the repository at this point in the history

  5. rename funcs

    @seaona
    seaona committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8c0516c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into quality-gate-gh

    @seaona
    seaona authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    bc6b76c View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. switch from sh to js file

    @seaona
    seaona committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    8179d2d View commit details
    Browse the repository at this point in the history

  2. fix changedfilesUtils

    @seaona
    seaona committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    27a4be3 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. move script to config file

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    af6e4d6 View commit details
    Browse the repository at this point in the history

  2. git diff incremental depth

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    e781327 View commit details
    Browse the repository at this point in the history

  3. fix git fetch incremental

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a26f7ea View commit details
    Browse the repository at this point in the history

  4. git fetch pr branch with depth too

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    cd0027f View commit details
    Browse the repository at this point in the history

  5. console log path

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    6ef0174 View commit details
    Browse the repository at this point in the history

  6. define output path

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    48482c8 View commit details
    Browse the repository at this point in the history

  7. format spec entries with path and new lines

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    b061ba5 View commit details
    Browse the repository at this point in the history

  8. fix back the spec files for testing ci

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    580eee5 View commit details
    Browse the repository at this point in the history

  9. only do for loop if there are changed e2e files

    @seaona
    seaona committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c3dbacf View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. update git diff fallback and adjust 

    depth intervals
    @seaona
    seaona committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2da87eb View commit details
    Browse the repository at this point in the history

  2. testing git diff with full checkout

    @seaona
    seaona committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    918e1fb View commit details
    Browse the repository at this point in the history

  3. fix fetch develop

    @seaona
    seaona committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6f429d3 View commit details
    Browse the repository at this point in the history

  4. unshallow

    @seaona
    seaona committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4ee548d View commit details
    Browse the repository at this point in the history

  5. separate job

    @seaona
    seaona committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    ab52848 View commit details
    Browse the repository at this point in the history

  6. remove requried job

    @seaona
    seaona committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    7726eb3 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'develop' into quality-gate-gh

    @seaona
    seaona committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    475764a View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'develop' into quality-gate-gh

    @seaona
    seaona authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    49ab885 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Merge branch 'develop' into quality-gate-gh

    @seaona
    seaona authored Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7cd00e4 View commit details
    Browse the repository at this point in the history

  2. addressing some of the review comments

    @seaona
    seaona committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    2d8a65a View commit details
    Browse the repository at this point in the history

  3. change .js to .ts

    @seaona
    seaona committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    94bae47 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. addressed comments and test failing test

    @seaona
    seaona committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5ebf061 View commit details
    Browse the repository at this point in the history

  2. update function name

    @seaona
    seaona committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0a548d2 View commit details
    Browse the repository at this point in the history

  3. add console logs and remove extra path

    @seaona
    seaona committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0821ecb View commit details
    Browse the repository at this point in the history

  4. tweak path

    @seaona
    seaona committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e91024c View commit details
    Browse the repository at this point in the history

  5. add missing /

    @seaona
    seaona committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    1eb2ea0 View commit details
    Browse the repository at this point in the history

  6. remove changes used to test ci

    @seaona
    seaona committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    89b6fc5 View commit details
    Browse the repository at this point in the history

  7. cleanup

    @seaona
    seaona committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fa71fa9 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. add missing newline Mark's suggestion 

    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    @seaona @Gudahtt
    seaona and Gudahtt authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    3e952e7 View commit details
    Browse the repository at this point in the history

  2. Omit type from tsdoc - Mark's suggestion 

    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    @seaona @Gudahtt
    seaona and Gudahtt authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2ae6c6f View commit details
    Browse the repository at this point in the history

  3. simplifying variables - Mark's suggestion 

    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    @seaona @Gudahtt
    seaona and Gudahtt authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    ecea19c View commit details
    Browse the repository at this point in the history

  4. avoid using any in ts - Mark's suggestion 

    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    @seaona @Gudahtt
    seaona and Gudahtt authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    eb79c08 View commit details
    Browse the repository at this point in the history

  5. add job comment for config

    @seaona
    seaona committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5874bb0 View commit details
    Browse the repository at this point in the history

  6. changed changedOrnew var definition

    @seaona
    seaona committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    9b1c7cc View commit details
    Browse the repository at this point in the history

  7. missing to remove the rest of the types in the descriptions - Mark's … 

    …suggestion

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    @seaona @Gudahtt
    seaona and Gudahtt authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0974070 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'develop' into quality-gate-gh

    @HowardBraham
    HowardBraham authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    07e81d8 View commit details
    Browse the repository at this point in the history