-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade transaction-controller to 32.0.0 to fix mmi #24947
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
34c4d5d
to
7bf5f4a
Compare
@metamaskbot update-policies |
Policies updated |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
b62d3a3
to
c5d5dea
Compare
@metamaskbot update-policies |
Policies updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@metamaskbot update-policies |
Policies updated |
Hi @dbrans, I noticed it had some conflicts with develop, so I went ahead and fixed them, think it looks good 👍🏼 |
Builds ready [83d3ffa]
Page Load Metrics (54 ± 5 ms)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24947 +/- ##
===========================================
- Coverage 67.37% 65.71% -1.66%
===========================================
Files 1278 1369 +91
Lines 49881 54397 +4516
Branches 12944 14155 +1211
===========================================
+ Hits 33605 35745 +2140
- Misses 16276 18652 +2376 ☔ View full report in Codecov by Sentry. |
Missing release label release-11.16.8 on PR. Adding release label release-11.16.8 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.8. |
Note
This PR is intended to be cherry-picked into RC 11.17.0 after being merged into develop
Description
Upgrade transaction-controller to get this fix: MetaMask/core#4343
Related issues
Fixes:
A recent update to the transaction-controller has made the TransactionMeta object passed to the afterSign hook frozen. This change prevents adding new properties, leading to the error: “Cannot add property custodyId, object is not extensible.” This bug is breaking all transactions for MMI as the original txMeta cannot store required properties like custodyId.
Blocked by #24861
Blocked by #24913
Manual testing steps
I followed these steps to test the fix:
You should see a popup with an Approve button. Before this fix, the transaction would appear in the activity tab with an error.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist