fix: upgrade transaction-controller to 32.0.0 to fix mmi

[dbrans]

Note

This PR is intended to be cherry-picked into RC 11.17.0 after being merged into develop

Description

Upgrade transaction-controller to get this fix: MetaMask/core#4343

Related issues

Fixes:
A recent update to the transaction-controller has made the TransactionMeta object passed to the afterSign hook frozen. This change prevents adding new properties, leading to the error: “Cannot add property custodyId, object is not extensible.” This bug is breaking all transactions for MMI as the original txMeta cannot store required properties like custodyId.

Blocked by #24861
Blocked by #24913

Manual testing steps

I followed these steps to test the fix:

1. yarn && yarn start:mmi
2. create a new wallet
3. visit https://saturn-custody-ui.dev.metamask-institutional.io/ and add two custodial addresses
4. send 0ETH from one custodial address to the other

You should see a popup with an Approve button. Before this fix, the transaction would appear in the activity tab with an error.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[dbrans]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[socket-security]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/nonce-tracker@5.0.0	None	0	0 B
npm/@metamask/transaction-controller@30.0.0	None	+2	81.4 kB

View full report↗︎

[dbrans]

@metamaskbot update-policies

[legobeat]

@dbrans Can we get this rebased on top of #24861 so we can update it 29 -> 30 -> 32? :)

Would be great to have the intermediary update to 30 merged independently so changed can be observed separately, I think?

[metamaskbot]

Policies updated

[zone-live]

LGTM!

[legobeat]

@zone-live #24861

[zone-live]

@metamaskbot update-policies

[metamaskbot]

Policies updated

[zone-live]

Hi @dbrans, I noticed it had some conflicts with develop, so I went ahead and fixed them, think it looks good 👍🏼

[metamaskbot]

Builds ready [83d3ffa]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (54 ± 5 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	118	84	11	5
		domContentLoaded	9	39	12	6	3
		load	43	79	54	10	5
		domInteractive	9	39	12	6	3

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.71%. Comparing base (d27a233) to head (83d3ffa).
Report is 242 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24947      +/-   ##
===========================================
- Coverage    67.37%   65.71%   -1.66%     
===========================================
  Files         1278     1369      +91     
  Lines        49881    54397    +4516     
  Branches     12944    14155    +1211     
===========================================
+ Hits         33605    35745    +2140     
- Misses       16276    18652    +2376     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[metamaskbot]

Missing release label release-11.16.8 on PR. Adding release label release-11.16.8 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.8.