Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Snaps codeowners list #25581

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 28, 2024

Description

This adds two more files to the Snaps codeowners list, which are important for the Snaps platform.

Closes #25522

@Mrtenz Mrtenz requested review from kumavis and a team as code owners June 28, 2024 10:37
@metamaskbot metamaskbot added INVALID-PR-TEMPLATE PR's body doesn't match template team-snaps-platform Snaps Platform team labels Jun 28, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [d39b564]
Page Load Metrics (167 ± 177 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint732181133115
domContentLoaded106934178
load421775167370177
domInteractive106934178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (fde960a) to head (d39b564).
Report is 8 commits behind head on develop.

Current head d39b564 differs from pull request most recent head 6101848

Please upload reports for the commit 6101848 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25581   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1358     1358           
  Lines        48134    48134           
  Branches     13288    13288           
========================================
  Hits         33503    33503           
  Misses       14631    14631           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Jul 11, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [f8fb24e]
Page Load Metrics (324 ± 297 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81136102147
domContentLoaded9392294
load491882324618297
domInteractive9392294
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Mrtenz Mrtenz merged commit 072ba38 into develop Jul 11, 2024
73 checks passed
@Mrtenz Mrtenz deleted the mrtenz/update-snaps-codeowners branch July 11, 2024 11:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Snaps CODEOWNERS
4 participants