Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for InvalidCustomNetworkAlert component #25600

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jun 29, 2024

Description

This PR introduces the Storybook story for the InvalidCustomNetworkAlert component, allowing for isolated development and testing of this UI component. The story was created to facilitate the visualization and interaction with the InvalidCustomNetworkAlert in various states, ensuring its robustness and responsiveness to different content and contexts.

Open in GitHub Codespaces

Related issues

  • None

Manual testing steps

  1. Go to the latest build of Storybook in this PR.
  2. Navigate to the InvalidCustomNetworkAlert component in the Components/ folder.
  3. Verify that the Storybook entry for this component is functioning correctly and displays as expected in various states.

Screenshots/Recordings

Screenshot 2024-07-23 at 5 55 26 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot marked this pull request as ready for review June 29, 2024 20:34
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner June 29, 2024 20:34
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 15, 2024
@georgewrmarshall georgewrmarshall requested a review from a team July 15, 2024 17:39
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request adds a Storybook entry for the InvalidCustomNetworkAlert component to facilitate its development and testing.

  • Added ui/components/app/alerts/invalid-custom-network-alert/invalid-custom-network-alert.stories.tsx to create a Storybook entry.
  • Configured a mock Redux store within the story to provide necessary state.
  • Wrapped the story with the Provider component to ensure Redux state access.
  • Included default arguments for the history prop required by the component.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Checked storybook ✅

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR introduces a Storybook story for the InvalidCustomNetworkAlert component, enabling isolated development and testing.

  • development/generate-rc-commits.js: Updated to fetch author teams mapping from a remote teams.json file, improving maintainability.
  • lavamoat/browserify/mmi/policy.json: Updated to include @metamask-institutional/types as a top-level dependency.
  • package.json: Added @metamask-institutional/types dependency and updated @metamask/bitcoin-wallet-snap version.
  • test/e2e/tests/settings/show-hex-data.spec.js: Updated selectors and added conditional logic for MMI environment variable.
  • test/e2e/vault-decryption-chrome.spec.js: Modified test setup for compatibility with production builds.

52 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

sonarcloud bot commented Jul 25, 2024

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR introduces a Storybook story for the InvalidCustomNetworkAlert component, enhancing isolated development and testing capabilities.

  • test/e2e/accounts/account-custom-name.spec.ts: Updated button click method to improve test reliability.
  • test/e2e/accounts/common.ts: Added delay to ensure popup closure before proceeding in installSnapSimpleKeyring.
  • test/e2e/accounts/create-snap-account.spec.ts: Introduced step to wait for popup closure, enhancing test stability.
  • test/e2e/webdriver/chrome.js: Locked Chrome browser version to 126 for consistent test results.
  • ui/components/app/import-token/token-list/token-list.component.js: Removed showHalo prop from AvatarToken, potentially affecting visual representation.

9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (83e4b2a) to head (f1fd27c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25600   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1405     1405           
  Lines        49728    49728           
  Branches     13748    13748           
========================================
  Hits         34646    34646           
  Misses       15082    15082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [f1fd27c]
Page Load Metrics (153 ± 172 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint742941094521
domContentLoaded95526105
load391707153358172
domInteractive95526105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall merged commit 98d792f into develop Jul 25, 2024
76 checks passed
@georgewrmarshall georgewrmarshall deleted the devin/story-HaX branch July 25, 2024 03:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants