-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create a story for InvalidCustomNetworkAlert component #25600
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request adds a Storybook entry for the InvalidCustomNetworkAlert
component to facilitate its development and testing.
- Added
ui/components/app/alerts/invalid-custom-network-alert/invalid-custom-network-alert.stories.tsx
to create a Storybook entry. - Configured a mock Redux store within the story to provide necessary state.
- Wrapped the story with the
Provider
component to ensure Redux state access. - Included default arguments for the
history
prop required by the component.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Checked storybook ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This PR introduces a Storybook story for the InvalidCustomNetworkAlert
component, enabling isolated development and testing.
development/generate-rc-commits.js
: Updated to fetch author teams mapping from a remoteteams.json
file, improving maintainability.lavamoat/browserify/mmi/policy.json
: Updated to include@metamask-institutional/types
as a top-level dependency.package.json
: Added@metamask-institutional/types
dependency and updated@metamask/bitcoin-wallet-snap
version.test/e2e/tests/settings/show-hex-data.spec.js
: Updated selectors and added conditional logic forMMI
environment variable.test/e2e/vault-decryption-chrome.spec.js
: Modified test setup for compatibility with production builds.
52 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This PR introduces a Storybook story for the InvalidCustomNetworkAlert
component, enhancing isolated development and testing capabilities.
test/e2e/accounts/account-custom-name.spec.ts
: Updated button click method to improve test reliability.test/e2e/accounts/common.ts
: Added delay to ensure popup closure before proceeding ininstallSnapSimpleKeyring
.test/e2e/accounts/create-snap-account.spec.ts
: Introduced step to wait for popup closure, enhancing test stability.test/e2e/webdriver/chrome.js
: Locked Chrome browser version to 126 for consistent test results.ui/components/app/import-token/token-list/token-list.component.js
: RemovedshowHalo
prop fromAvatarToken
, potentially affecting visual representation.
9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25600 +/- ##
========================================
Coverage 69.67% 69.67%
========================================
Files 1405 1405
Lines 49728 49728
Branches 13748 13748
========================================
Hits 34646 34646
Misses 15082 15082 ☔ View full report in Codecov by Sentry. |
Builds ready [f1fd27c]
Page Load Metrics (153 ± 172 ms)
Bundle size diffs
|
Description
This PR introduces the Storybook story for the
InvalidCustomNetworkAlert
component, allowing for isolated development and testing of this UI component. The story was created to facilitate the visualization and interaction with theInvalidCustomNetworkAlert
in various states, ensuring its robustness and responsiveness to different content and contexts.Related issues
Manual testing steps
InvalidCustomNetworkAlert
component in the Components/ folder.Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist