Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated switch to this account condition #25609

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Jul 1, 2024

On the connections, if user has only one account connected and that account is not the selected account, the account list item options wasn't showing switch to this account option. This PR fixes it

NOTE: If reviewers are not able to check the connections page on develop (That work is done via this PR #25500). Please route to connections page via all permissions

Related issues

Fixes: NA

Manual testing steps

  1. Connect single account in MetaMask to a Dapp
  2. Switch to an account which is not connected to the Dapp
  3. Go to Connections Page, click the three dot menu
  4. Switch to this account option should show
  5. Switch to this account option should not show when there is only one account connected to Dapp and that is also the selected account

Screenshots/Recordings

Before

Screen.Recording.2024-07-01.at.11.44.52.AM.mov

After

Screen.Recording.2024-07-01.at.11.54.56.AM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner July 1, 2024 10:45
@NidhiKJha NidhiKJha added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Jul 1, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 1, 2024
Copy link

sonarcloud bot commented Jul 17, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [654e279]
Page Load Metrics (84 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81143113178
domContentLoaded106434168
load4611884199
domInteractive106434168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 75 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.75%. Comparing base (8c519db) to head (654e279).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25609   +/-   ##
========================================
  Coverage    69.75%   69.75%           
========================================
  Files         1400     1400           
  Lines        49199    49201    +2     
  Branches     13578    13579    +1     
========================================
+ Hits         34318    34320    +2     
  Misses       14881    14881           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NidhiKJha NidhiKJha merged commit 09eab65 into develop Jul 22, 2024
79 checks passed
@NidhiKJha NidhiKJha deleted the switch-account-fix branch July 22, 2024 10:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants