-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated switch to this account condition #25609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
added
team-wallet-ux
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
labels
Jul 1, 2024
darkwing
approved these changes
Jul 1, 2024
sahar-fehri
approved these changes
Jul 17, 2024
Quality Gate passedIssues Measures |
Builds ready [654e279]
Page Load Metrics (84 ± 9 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25609 +/- ##
========================================
Coverage 69.75% 69.75%
========================================
Files 1400 1400
Lines 49199 49201 +2
Branches 13578 13579 +1
========================================
+ Hits 34318 34320 +2
Misses 14881 14881 ☔ View full report in Codecov by Sentry. |
metamaskbot
added
the
release-12.3.0
Issue or pull request that will be included in release 12.3.0
label
Jul 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-12.3.0
Issue or pull request that will be included in release 12.3.0
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the connections, if user has only one account connected and that account is not the selected account, the account list item options wasn't showing switch to this account option. This PR fixes it
NOTE: If reviewers are not able to check the connections page on develop (That work is done via this PR #25500). Please route to connections page via all permissions
Related issues
Fixes: NA
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-07-01.at.11.44.52.AM.mov
After
Screen.Recording.2024-07-01.at.11.54.56.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist