Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BTC support survey link #25875

Merged
merged 1 commit into from
Jul 18, 2024
Merged

feat: add BTC support survey link #25875

merged 1 commit into from
Jul 18, 2024

Conversation

gantunesr
Copy link
Member

@gantunesr gantunesr commented Jul 16, 2024

Description

Open in GitHub Codespaces

add BTC support survey link (https://www.getfeedback.com/r/yG6FbiW5)

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/522

Manual testing steps

  1. Install Flask and create a wallet
  2. Go into the experimental settings
  3. Validate that the BTC support toggle has the correct survey link

Screenshots/Recordings

Screenshot 2024-07-16 at 5 18 12 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

sonarcloud bot commented Jul 16, 2024

@gantunesr gantunesr marked this pull request as ready for review July 16, 2024 21:24
@gantunesr gantunesr requested a review from a team as a code owner July 16, 2024 21:24
Copy link
Contributor

@owencraston owencraston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@metamaskbot
Copy link
Collaborator

Builds ready [e7ac268]
Page Load Metrics (153 ± 166 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint722971114924
domContentLoaded99729199
load461657153347166
domInteractive99729199
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 237 Bytes (0.00%)

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.76%. Comparing base (20f54db) to head (e7ac268).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25875   +/-   ##
========================================
  Coverage    69.76%   69.76%           
========================================
  Files         1398     1398           
  Lines        49171    49171           
  Branches     13574    13574           
========================================
  Hits         34303    34303           
  Misses       14868    14868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shared/constants/urls.ts Show resolved Hide resolved
app/_locales/en/messages.json Show resolved Hide resolved
@gantunesr gantunesr merged commit f60b43e into develop Jul 18, 2024
87 of 88 checks passed
@gantunesr gantunesr deleted the feat/btc-survey branch July 18, 2024 18:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 18, 2024
@metamaskbot metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Aug 30, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.3.0), as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants