fix: notification slowness and crashes

[Prithpal-Sooriya]

Description

This is a series of fixes added to core libraries. Adding to extension, and soon we will migrate extension to use shared libraries.

Related issues

MetaMask/core#4530
MetaMask/core#4531
MetaMask/core#4532
MetaMask/core#4533
MetaMask/core#4536

#25749

Manual testing steps

1. Create multiple accounts
2. Go to notification settings page
3. Wait for settings to load, and try toggling notifications

Before: some settings would error or not load
After: you should be able to toggle accounts and not see errors.

Screenshots/Recordings

Before

After

https://www.loom.com/share/49b582e8c33b4199bdafc994a3f6087f?sid=9f94a885-351b-4fee-84d8-f72c97506e7d

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [f8f0dae]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (237 ± 243 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	146	101	20	9
		domContentLoaded	8	65	24	15	7
		load	40	1862	237	505	243
		domInteractive	8	65	24	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 561 Bytes (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [5f76720]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (151 ± 191 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	131	91	17	8
		domContentLoaded	9	53	23	13	6
		load	40	1883	151	398	191
		domInteractive	9	53	22	13	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 561 Bytes (0.02%)
• ui: 1.08 KiB (0.01%)
• common: 0 Bytes (0.00%)

[codecov]

Codecov Report

Attention: Patch coverage is 30.85106% with 65 lines in your changes missing coverage. Please review.

Project coverage is 69.67%. Comparing base (e562224) to head (3902451).

Files	Patch %	Lines
...s/metamask-notifications/useSwitchNotifications.ts	0.00%	30 Missing ⚠️
...ns-settings/notifications-settings-per-account.tsx	0.00%	18 Missing ⚠️
.../notifications-settings/notifications-settings.tsx	0.00%	10 Missing ⚠️
...s/metamask-notifications/metamask-notifications.ts	66.67%	3 Missing ⚠️
...ollers/authentication/authentication-controller.ts	81.82%	2 Missing ⚠️
...sk-notifications/services/feature-announcements.ts	88.89%	1 Missing ⚠️
...ontrollers/user-storage/user-storage-controller.ts	83.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25946      +/-   ##
===========================================
- Coverage    69.70%   69.67%   -0.03%     
===========================================
  Files         1400     1400              
  Lines        49464    49510      +46     
  Branches     13687    13689       +2     
===========================================
+ Hits         34478    34494      +16     
- Misses       14986    15016      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matteoscurati]

I found two edge cases regarding state management, but they involve behaviors that a user normally wouldn’t apply and, in any case, they don’t cause issues in managing the extension’s state. We can approve this PR and look into further optimizing this page in the future :)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [3902451]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (70 ± 9 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	62	140	99	18	9
		domContentLoaded	10	64	26	14	7
		load	42	110	70	18	9
		domInteractive	10	64	26	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 561 Bytes (0.02%)
• ui: 1.08 KiB (0.01%)
• common: 0 Bytes (0.00%)

[metamaskbot]

More than one release label on PR. Keeping the lowest one (release-12.0.0) on PR and removing other release labels (release-12.3.0).