-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Bitcoin Snap to version 0.2.5 #26058
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/bitcoin-wallet-snap@0.2.4 |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@SocketSecurity ignore npm/@metamask/bitcoin-wallet-snap@0.2.5 It's used to send requests to a backend service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Updated the @metamask/btc-wallet-snap
dependency to version 0.2.5 to address a bug related to custom RPC loading.
- Dependency Update: Modified
package.json
to update@metamask/btc-wallet-snap
from^0.2.4
to^0.2.5
. - Bug Fix: Aimed at resolving issue Fix bug where custom rpc appears loading #534 where custom RPC appears loading.
- Testing: Ensure the new dependency version does not introduce regressions or new bugs.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26058 +/- ##
========================================
Coverage 69.69% 69.69%
========================================
Files 1405 1405
Lines 49723 49723
Branches 13740 13740
========================================
Hits 34650 34650
Misses 15073 15073 ☔ View full report in Codecov by Sentry. |
Builds ready [2a52350]
Page Load Metrics (75 ± 15 ms)
Bundle size diffs
|
Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.3.0), as PR was cherry-picked in branch 12.2.0. |
Description
This PR updates the
@metamask/btc-wallet-snap
to version 0.2.5.Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/534
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist