Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Bitcoin Snap to version 0.2.5 #26058

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Jul 23, 2024

Description

This PR updates the @metamask/btc-wallet-snap to version 0.2.5.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/534

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@danroc danroc changed the title Dr/update btc snap chore: update Bitcoin Snap to version 0.2.5 Jul 23, 2024
Copy link

socket-security bot commented Jul 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/bitcoin-wallet-snap@0.2.5 network 0 1.01 MB metamaskbot

🚮 Removed packages: npm/@metamask/bitcoin-wallet-snap@0.2.4

View full report↗︎

Copy link

socket-security bot commented Jul 23, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/bitcoin-wallet-snap@0.2.5

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@danroc danroc self-assigned this Jul 23, 2024
@danroc
Copy link
Contributor Author

danroc commented Jul 23, 2024

@SocketSecurity ignore npm/@metamask/bitcoin-wallet-snap@0.2.5

It's used to send requests to a backend service.

@danroc danroc marked this pull request as ready for review July 23, 2024 17:59
@danroc danroc requested a review from a team as a code owner July 23, 2024 17:59
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated the @metamask/btc-wallet-snap dependency to version 0.2.5 to address a bug related to custom RPC loading.

  • Dependency Update: Modified package.json to update @metamask/btc-wallet-snap from ^0.2.4 to ^0.2.5.
  • Bug Fix: Aimed at resolving issue Fix bug where custom rpc appears loading #534 where custom RPC appears loading.
  • Testing: Ensure the new dependency version does not introduce regressions or new bugs.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

sonarcloud bot commented Jul 23, 2024

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (b262267) to head (2a52350).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26058   +/-   ##
========================================
  Coverage    69.69%   69.69%           
========================================
  Files         1405     1405           
  Lines        49723    49723           
  Branches     13740    13740           
========================================
  Hits         34650    34650           
  Misses       15073    15073           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [2a52350]
Page Load Metrics (75 ± 15 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint622101043014
domContentLoaded96929189
load40191753115
domInteractive96929189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -24.35 KiB (-0.32%)
  • common: 0 Bytes (0.00%)

@danroc danroc merged commit 2a23c7b into develop Jul 24, 2024
76 checks passed
@danroc danroc deleted the dr/update-btc-snap branch July 24, 2024 07:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 24, 2024
@metamaskbot metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.3.0 Issue or pull request that will be included in release 12.3.0 labels Aug 30, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.3.0), as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants