Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @metamask/bitcoin-wallet-snap to 0.3.0 #26168

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Jul 26, 2024

Description

Bump the BTC Snap to version 0.3.0.

  • This new release adds the fee estimation feature.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly requested a review from a team as a code owner July 26, 2024 16:12
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/bitcoin-wallet-snap@0.3.0 network 0 1.02 MB metamaskbot

🚮 Removed packages: npm/@metamask/bitcoin-wallet-snap@0.2.5

View full report↗︎

Copy link

sonarcloud bot commented Jul 26, 2024

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jul 26, 2024
@ccharly
Copy link
Contributor Author

ccharly commented Jul 26, 2024

I was able get the fee estimation by modifying our test Bitcoin dapp locally, see here:

  • No external has been installed
  • I was able to call the fee estimate RPC

Screenshot 2024-07-26 at 18 26 53

@metamaskbot
Copy link
Collaborator

Builds ready [8f40cde]
Page Load Metrics (132 ± 141 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5913695189
domContentLoaded85428147
load391408132293141
domInteractive85428147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.39 KiB (0.02%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (08c7333) to head (8f40cde).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #26168   +/-   ##
========================================
  Coverage    69.93%   69.93%           
========================================
  Files         1409     1409           
  Lines        49809    49809           
  Branches     13780    13780           
========================================
  Hits         34832    34832           
  Misses       14977    14977           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ccharly ccharly merged commit efbdd42 into develop Jul 29, 2024
84 checks passed
@ccharly ccharly deleted the feature/use-bitcoin-wallet-snap-0.3.0-release branch July 29, 2024 08:25
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 29, 2024
@metamaskbot metamaskbot added release-12.2.0 Issue or pull request that will be included in release 12.2.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Aug 30, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.4.0), as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants