chore: bump `eth-ledger-bridge-keyring` to `^3.0.1` #26498

mikesposito · 2024-08-19T14:13:35Z

Description

This PR updates the eth-ledger-bridge-keyring package to ^3.0.1. See CHANGELOG.md for more details on the changes we are bringing in.

Note that we are not updating to the latest major version (4), because a change in the package dependencies in the last major version caused a bundle size increase of ~1.2MB

Related issues

Progresses #26840

Manual testing steps

All interactions with the Ledger device should be tested manually.

Connect a Ledger account
Sign transaction
Sign personal message
Sign typed message
Remove Ledger account

Screenshots/Recordings

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

socket-security · 2024-08-19T14:14:59Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@babel/helper-annotate-as-pure@7.22.5	None	`0`	4.02 kB	nicolo-ribaudo
npm/@babel/helper-replace-supers@7.24.1	None	`0`	32.2 kB	nicolo-ribaudo
npm/@babel/helper-skip-transparent-expression-wrappers@7.22.5	None	`0`	5.96 kB	nicolo-ribaudo
npm/@metamask/eth-ledger-bridge-keyring@3.0.1	None	`0`	105 kB	gudahtt
npm/caniuse-lite@1.0.30001600	None	`0`	2 MB	caniuse-lite
npm/escalade@3.1.1	filesystem	`0`	11.4 kB	lukeed
npm/picocolors@1.0.0	environment	`0`	5.66 kB	alexeyraspopov

🚮 Removed packages: npm/@babel/helper-annotate-as-pure@7.24.7), npm/@babel/helper-replace-supers@7.24.7), npm/@babel/helper-skip-transparent-expression-wrappers@7.24.7), npm/caniuse-lite@1.0.30001643), npm/picocolors@1.0.1)

View full report↗︎

The patch has been ported upstream

mikesposito · 2024-08-19T18:58:01Z

@metamaskbot update-policies

metamaskbot · 2024-08-19T19:09:27Z

Policies updated

mikesposito · 2024-08-20T13:05:53Z

.yarn/patches/@metamask-eth-ledger-bridge-keyring-npm-2.0.1-7a5d815b2d.patch

The patch has been ported upstream

@mikesposito Looks like the change is not present anymore after downgrading this PR to 3.0.1 as it was merged after release of v4? Should the patch be brought back for now?

Is it all good it was merged without the patch?

package.json

metamaskbot · 2024-08-20T13:53:00Z

Builds ready [230d7c4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (73 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	161	98	22	11
		domContentLoaded	45	114	68	19	9
		load	51	114	73	17	8
		domInteractive	9	61	24	11	5

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.17 MiB (35.82%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-08-20T13:53:18Z

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.16%. Comparing base (416d024) to head (b2892a7).

Files with missing lines	Patch %	Lines
...ts/lib/offscreen-bridge/ledger-offscreen-bridge.ts	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #26498      +/-   ##
===========================================
- Coverage    70.17%   70.16%   -0.01%     
===========================================
  Files         1425     1425              
  Lines        49659    49663       +4     
  Branches     13891    13891              
===========================================
  Hits         34846    34846              
- Misses       14813    14817       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mikesposito · 2024-08-20T14:04:24Z

Bundle size diffs [🚨 Warning! Bundle size has increased!]
background: 1.17 MiB (35.82%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

Hmm, this is alarming. Looking into it now

mikesposito · 2024-08-22T15:26:06Z

We decided to create a backport release of the patch we need to bring to the extension, while we investigate for a long term solution to the package size issue

yarn.lock

mikesposito · 2024-09-03T10:48:10Z

@metamaskbot update-policies

metamaskbot · 2024-09-03T10:59:23Z

Policies updated

metamaskbot · 2024-09-03T11:31:01Z

Builds ready [a0bfadc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1710 ± 95 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	209	2050	1365	571	274
		domContentLoaded	1439	2119	1692	193	93
		load	1459	2123	1710	197	95
		domInteractive	20	83	32	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 885 Bytes (0.03%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-09-04T08:07:16Z

Builds ready [21fd490]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1867 ± 53 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	241	2044	1709	452	217
		domContentLoaded	1703	2186	1848	108	52
		load	1717	2188	1867	110	53
		domInteractive	14	228	44	43	21

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 885 Bytes (0.03%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

cryptodev-2s

LGTM!

metamaskbot · 2024-09-05T13:13:42Z

Builds ready [5136c2e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1955 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	245	2411	1759	527	253
		domContentLoaded	1603	2368	1921	196	94
		load	1613	2398	1955	208	100
		domInteractive	18	82	36	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 885 Bytes (0.03%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

MajorLift

LGTM!

sonarcloud · 2024-09-09T07:59:13Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-09T08:27:12Z

Builds ready [b2892a7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1720 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	331	1956	1651	322	155
		domContentLoaded	1560	1938	1698	113	54
		load	1568	1958	1720	113	54
		domInteractive	14	188	39	37	18

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 885 Bytes (0.03%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

kanthesha

LGTM.

desi

LGTM

chore: update eth-ledger-bridge-keyring

58e440a

metamaskbot added the team-wallet-framework label Aug 19, 2024

mikesposito added 2 commits August 19, 2024 16:29

chore: remove unused patch

a1e92c9

The patch has been ported upstream

deps: fix axios audit

e37acf9

Update LavaMoat policies

028a590

mikesposito added 2 commits August 20, 2024 14:47

fix: add LedgerOffscreenBridgeOptions type

aa49c62

Merge branch 'develop' into chore/update-ledger-keyring

230d7c4

mikesposito commented Aug 20, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

mikesposito marked this pull request as ready for review August 20, 2024 13:52

mikesposito requested review from a team as code owners August 20, 2024 13:52

mikesposito requested a review from a team August 20, 2024 13:55

legobeat reviewed Aug 23, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

mikesposito added 2 commits September 3, 2024 11:20

refactor: downgrade to ^3.0.1

4e2909b

Merge branch 'develop' into chore/update-ledger-keyring

d95d145

Update LavaMoat policies

a0bfadc

mikesposito changed the title ~~chore: update eth-ledger-bridge-keyring~~ deps: bump eth-ledger-bridge-keyring Sep 3, 2024

mikesposito changed the title ~~deps: bump eth-ledger-bridge-keyring~~ chore: bump eth-ledger-bridge-keyring Sep 3, 2024

mikesposito changed the title ~~chore: bump eth-ledger-bridge-keyring~~ chore: bump eth-ledger-bridge-keyring to ^3.0.1 Sep 3, 2024

chore: remove resolution

21fd490

cryptodev-2s previously approved these changes Sep 4, 2024

View reviewed changes

Merge branch 'develop' into chore/update-ledger-keyring

5136c2e

mikesposito dismissed cryptodev-2s’s stale review via 5136c2e September 5, 2024 12:40

mikesposito requested review from cryptodev-2s and legobeat September 5, 2024 12:44

MajorLift approved these changes Sep 6, 2024

View reviewed changes

Merge branch 'develop' into chore/update-ledger-keyring

b2892a7

kanthesha approved these changes Sep 9, 2024

View reviewed changes

desi approved these changes Sep 9, 2024

View reviewed changes

mikesposito merged commit d6d43eb into develop Sep 9, 2024
78 checks passed

mikesposito deleted the chore/update-ledger-keyring branch September 9, 2024 15:09

github-actions bot locked and limited conversation to collaborators Sep 9, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 9, 2024

gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump `eth-ledger-bridge-keyring` to `^3.0.1` #26498

chore: bump `eth-ledger-bridge-keyring` to `^3.0.1` #26498

mikesposito commented Aug 19, 2024 •

edited

Loading

socket-security bot commented Aug 19, 2024 •

edited

Loading

mikesposito commented Aug 19, 2024

metamaskbot commented Aug 19, 2024

mikesposito Aug 20, 2024

legobeat Sep 8, 2024 •

edited

Loading

legobeat Sep 10, 2024

metamaskbot commented Aug 20, 2024

codecov bot commented Aug 20, 2024 •

edited

Loading

mikesposito commented Aug 20, 2024

mikesposito commented Aug 22, 2024 •

edited

Loading

mikesposito commented Sep 3, 2024

metamaskbot commented Sep 3, 2024

metamaskbot commented Sep 3, 2024

metamaskbot commented Sep 4, 2024

cryptodev-2s left a comment

metamaskbot commented Sep 5, 2024

MajorLift left a comment

sonarcloud bot commented Sep 9, 2024

metamaskbot commented Sep 9, 2024

kanthesha left a comment

desi left a comment

chore: bump eth-ledger-bridge-keyring to ^3.0.1 #26498

chore: bump eth-ledger-bridge-keyring to ^3.0.1 #26498

Conversation

mikesposito commented Aug 19, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

socket-security bot commented Aug 19, 2024 • edited Loading

mikesposito commented Aug 19, 2024

metamaskbot commented Aug 19, 2024

mikesposito Aug 20, 2024

Choose a reason for hiding this comment

legobeat Sep 8, 2024 • edited Loading

Choose a reason for hiding this comment

legobeat Sep 10, 2024

Choose a reason for hiding this comment

metamaskbot commented Aug 20, 2024

codecov bot commented Aug 20, 2024 • edited Loading

Codecov Report

mikesposito commented Aug 20, 2024

mikesposito commented Aug 22, 2024 • edited Loading

mikesposito commented Sep 3, 2024

metamaskbot commented Sep 3, 2024

metamaskbot commented Sep 3, 2024

metamaskbot commented Sep 4, 2024

cryptodev-2s left a comment

Choose a reason for hiding this comment

metamaskbot commented Sep 5, 2024

MajorLift left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Sep 9, 2024

Quality Gate passed

metamaskbot commented Sep 9, 2024

kanthesha left a comment

Choose a reason for hiding this comment

desi left a comment

Choose a reason for hiding this comment

chore: bump `eth-ledger-bridge-keyring` to `^3.0.1` #26498

chore: bump `eth-ledger-bridge-keyring` to `^3.0.1` #26498

mikesposito commented Aug 19, 2024 •

edited

Loading

socket-security bot commented Aug 19, 2024 •

edited

Loading

legobeat Sep 8, 2024 •

edited

Loading

codecov bot commented Aug 20, 2024 •

edited

Loading

mikesposito commented Aug 22, 2024 •

edited

Loading