Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Sentry 8 (#25999) [cherry-pick] #26618

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 22, 2024

This PR cherry-picks #25999 to v12.1.0. Original description:

Description

Upgrade the Sentry packages from 7.53.0 to 8.19.0.

Specifically:

  • Refactor custom FilterEvents integration into object returned by function.
  • Remove usages of hub.
  • Fix notification errors when changing metrics preference.

Open in GitHub Codespaces

Related issues

Manual testing steps

Full Sentry regression.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Refactor custom `FilterEvents` integration into object returned by function.
Remove usages of `hub`.
Fix notification errors when changing metrics preference.
@Gudahtt Gudahtt force-pushed the cherry-pick/update-to-sentry-8 branch from 374f1b8 to b5bbdde Compare August 22, 2024 16:04
Copy link

socket-security bot commented Aug 22, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@sentry-internal/browser-utils@8.19.0, npm/@sentry/core@8.19.0, npm/@sentry/utils@8.19.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 22, 2024

@metamaskbot update-policies

@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 22, 2024

For reviewers, I would recommend reviewing the code to make sure I didn't make any mistakes when merging conflicts, but we can save manual testing for later. There are three Sentry-related PRs we will be cherry-picking in, which this is the first of. We can do a full Sentry regression test on all three changes together.

@metamaskbot
Copy link
Collaborator

Policies updated

@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 22, 2024

@SocketSecurity ignore npm/@sentry-internal/browser-utils@8.19.0
@SocketSecurity ignore npm/@sentry/core@8.19.0
@SocketSecurity ignore npm/@sentry/utils@8.19.0

These are intended to have network access

@Gudahtt Gudahtt changed the title chore: upgrade to Sentry 8 (#25999) chore: upgrade to Sentry 8 (#25999) [cherry-pick] Aug 22, 2024
@Gudahtt Gudahtt marked this pull request as ready for review August 22, 2024 16:50
@Gudahtt Gudahtt requested review from a team and kumavis as code owners August 22, 2024 16:50
@metamaskbot
Copy link
Collaborator

Builds ready [5d4bd9d]
Page Load Metrics (148 ± 142 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint662761175627
domContentLoaded9173343718
load391414148295142
domInteractive9173343718

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.

Project coverage is 69.83%. Comparing base (4d299d8) to head (5d4bd9d).
Report is 1 commits behind head on Version-v12.1.0.

Files Patch % Lines
app/scripts/lib/setupSentry.js 0.00% 11 Missing ⚠️
app/scripts/lib/sentry-filter-events.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           Version-v12.1.0   #26618   +/-   ##
================================================
  Coverage            69.83%   69.83%           
================================================
  Files                 1368     1368           
  Lines                48655    48653    -2     
  Branches             13435    13434    -1     
================================================
+ Hits                 33974    33975    +1     
+ Misses               14681    14678    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hjetpoluru hjetpoluru self-requested a review August 22, 2024 18:43
@Gudahtt Gudahtt merged commit b0d1067 into Version-v12.1.0 Aug 22, 2024
70 checks passed
@Gudahtt Gudahtt deleted the cherry-pick/update-to-sentry-8 branch August 22, 2024 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 28, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants