-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Sentry 8 (#25999) [cherry-pick] #26618
Conversation
Refactor custom `FilterEvents` integration into object returned by function. Remove usages of `hub`. Fix notification errors when changing metrics preference.
374f1b8
to
b5bbdde
Compare
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@sentry-internal/tracing@7.53.0), npm/@sentry/browser@7.53.0), npm/@sentry/core@7.53.0), npm/@sentry/integrations@7.53.0), npm/@sentry/replay@7.53.0), npm/@sentry/types@7.53.0), npm/@sentry/utils@7.53.0) |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
@metamaskbot update-policies |
For reviewers, I would recommend reviewing the code to make sure I didn't make any mistakes when merging conflicts, but we can save manual testing for later. There are three Sentry-related PRs we will be cherry-picking in, which this is the first of. We can do a full Sentry regression test on all three changes together. |
Policies updated |
@SocketSecurity ignore npm/@sentry-internal/browser-utils@8.19.0 These are intended to have network access |
Builds ready [5d4bd9d]
Page Load Metrics (148 ± 142 ms)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## Version-v12.1.0 #26618 +/- ##
================================================
Coverage 69.83% 69.83%
================================================
Files 1368 1368
Lines 48655 48653 -2
Branches 13435 13434 -1
================================================
+ Hits 33974 33975 +1
+ Misses 14681 14678 -3 ☔ View full report in Codecov by Sentry. |
No release label on PR. Adding release label release-12.2.0 on PR, as PR was cherry-picked in branch 12.2.0. |
This PR cherry-picks #25999 to v12.1.0. Original description:
Description
Upgrade the Sentry packages from
7.53.0
to8.19.0
.Specifically:
FilterEvents
integration into object returned by function.hub
.Related issues
Manual testing steps
Full Sentry regression.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist