-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding context to get current confirmation PR-3 #26645
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
b8fb226
to
119e446
Compare
119e446
to
c6280c2
Compare
Builds ready [59d707a]
Page Load Metrics (83 ± 9 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26645 +/- ##
===========================================
- Coverage 70.12% 70.11% -0.01%
===========================================
Files 1421 1422 +1
Lines 49524 49526 +2
Branches 13863 13863
===========================================
- Hits 34728 34725 -3
- Misses 14796 14801 +5 ☔ View full report in Codecov by Sentry. |
const currentConfirmation = useSelector(currentConfirmationSelector) as | ||
| TransactionMeta | ||
| undefined; | ||
const { currentConfirmation } = useConfirmContext() as unknown as { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, is it worth using a template on useConfirmContext
to avoid the casting in future?
Something like:
const { currentConfirmation } = useConfirmContext<TransactionMeta>();
Builds ready [9d87c7b]
Page Load Metrics (1884 ± 67 ms)
Bundle size diffs
|
Quality Gate passedIssues Measures |
Builds ready [17a2c63]
Page Load Metrics (1664 ± 61 ms)
Bundle size diffs
|
Description
Using context to get currently selected confirmation in re-designed confirmation pages. This is done to switch to using react context transient UI state in re-designed confirmation pages.
Related issues
Ref: #26414
Manual testing steps
NA
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist